Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UsaNavDropdownButton active class #828

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Fix UsaNavDropdownButton active class #828

merged 4 commits into from
Feb 24, 2024

Conversation

patrickcate
Copy link
Owner

No description provided.

…not being applied to button

When using `router-link` or `nuxt-link` the active class was not being applied to the button element
because the `to` prop wasn't being passed.
…n-button

Feature/000/nav menu dropdown button
@patrickcate patrickcate self-assigned this Feb 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (d87438f) to head (cbf53cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   99.40%   99.48%   +0.07%     
==========================================
  Files         110      110              
  Lines        2517     2518       +1     
  Branches      390      390              
==========================================
+ Hits         2502     2505       +3     
+ Misses         13       11       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickcate patrickcate merged commit 7db6f12 into main Feb 24, 2024
10 checks passed
@patrickcate
Copy link
Owner Author

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants