Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-12-27 Release #788

Merged
merged 31 commits into from
Dec 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f1650d6
fix(UsaRange): remove redundant ARIA attributes
patrickcate Dec 17, 2023
dc2bc92
feat(UsaRange): add `unit` and `preposition` props
patrickcate Dec 18, 2023
42ea002
feat: incorporate date picker a11y improvements from USWDS 3.7.0
patrickcate Dec 18, 2023
885e73c
chore (npm): bump eslint from 8.55.0 to 8.56.0
dependabot[bot] Dec 18, 2023
160e645
chore (github-actions): bump github/codeql-action from 2 to 3
dependabot[bot] Dec 18, 2023
13691fc
Merge pull request #776 from patrickcate/dependabot/npm_and_yarn/esli…
dependabot[bot] Dec 18, 2023
3031971
chore (npm): bump @cypress/code-coverage from 3.12.13 to 3.12.14
dependabot[bot] Dec 18, 2023
8c6a38c
Merge pull request #777 from patrickcate/dependabot/npm_and_yarn/cypr…
dependabot[bot] Dec 18, 2023
50f31f1
chore (npm): bump @vitejs/plugin-vue from 4.5.1 to 4.5.2
dependabot[bot] Dec 18, 2023
5c341a9
Merge pull request #779 from patrickcate/dependabot/npm_and_yarn/vite…
dependabot[bot] Dec 18, 2023
da9061a
chore (npm): bump vue from 3.3.11 to 3.3.12
dependabot[bot] Dec 18, 2023
f44ab50
Merge pull request #778 from patrickcate/dependabot/npm_and_yarn/vue-…
dependabot[bot] Dec 18, 2023
f6cdd96
chore (npm): bump @babel/core from 7.23.5 to 7.23.6
dependabot[bot] Dec 18, 2023
82536de
Merge pull request #780 from patrickcate/dependabot/npm_and_yarn/babe…
dependabot[bot] Dec 18, 2023
46d85cd
Merge branch 'develop' into dependabot/github_actions/github/codeql-a…
patrickcate Dec 18, 2023
3fe0c9f
feat: incorporate date picker a11y improvements from USWDS 3.7.0
patrickcate Dec 18, 2023
8fd395c
Merge pull request #781 from patrickcate/dependabot/github_actions/gi…
patrickcate Dec 18, 2023
683c3f8
Merge branch 'develop' into feature/000/date-picker-a11y
patrickcate Dec 18, 2023
02e1b2d
Merge pull request #782 from patrickcate/feature/000/date-picker-a11y
patrickcate Dec 18, 2023
bf507ab
chore: fix git merge conflict
patrickcate Dec 18, 2023
e0a124d
chore (npm): bump vue from 3.3.12 to 3.3.13
dependabot[bot] Dec 25, 2023
e21fca8
Merge pull request #783 from patrickcate/dependabot/npm_and_yarn/vue-…
dependabot[bot] Dec 25, 2023
d8f9ff5
chore (npm): bump @vitejs/plugin-vue from 4.5.2 to 4.6.0
dependabot[bot] Dec 25, 2023
6fe225c
Merge pull request #785 from patrickcate/dependabot/npm_and_yarn/vite…
dependabot[bot] Dec 25, 2023
032824f
chore (npm): bump vue-loader from 17.3.1 to 17.4.0
dependabot[bot] Dec 25, 2023
4fd7fb3
Merge pull request #784 from patrickcate/dependabot/npm_and_yarn/vue-…
dependabot[bot] Dec 25, 2023
5e81678
chore (npm): bump @cypress/code-coverage from 3.12.14 to 3.12.15
dependabot[bot] Dec 25, 2023
3b88883
Merge pull request #786 from patrickcate/dependabot/npm_and_yarn/cypr…
dependabot[bot] Dec 25, 2023
7d550ac
chore(npm): update npm dependencies
patrickcate Dec 27, 2023
827dd80
refactor: add un-used `props` variable so code coverage is calculated…
patrickcate Dec 27, 2023
0325da5
Merge pull request #787 from patrickcate/support/000/2023-12-27-updates
patrickcate Dec 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -55,7 +55,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
Expand All @@ -68,4 +68,4 @@ jobs:
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
1,369 changes: 716 additions & 653 deletions package-lock.json

Large diffs are not rendered by default.

18 changes: 8 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
},
"dependencies": {
"@floating-ui/dom": "^1.0.4",
"@vueuse/components": "^9.4.0",
"@vueuse/core": "^9.4.0",
"@vueuse/integrations": "^9.4.0",
"@vueuse/components": "^10.7.0",
"@vueuse/core": "^10.7.0",
"@vueuse/integrations": "^10.7.0",
"date-fns": "^2.28.0",
"fast-sort": "^3.1.3",
"focus-trap": "^7.0.0",
Expand All @@ -79,8 +79,6 @@
"@commitlint/cli": "^17.0.2",
"@commitlint/config-conventional": "^17.0.2",
"@cypress/code-coverage": "^3.9.12",
"@cypress/vite-dev-server": "^2.2.0",
"@cypress/vue": "^4.0.0",
"@semantic-release/changelog": "^6.0.1",
"@semantic-release/git": "^10.0.1",
"@storybook/addon-actions": "^6.4.0",
Expand All @@ -96,8 +94,8 @@
"babel-loader": "^8.2.3",
"commitizen": "^4.2.4",
"cross-env": "^7.0.3",
"cypress": "^13.6.1",
"cypress-real-events": "^1.5.1",
"cypress": "^13.6.2",
"cypress-real-events": "^1.11.0",
"cz-customizable": "^6.3.0",
"eslint": "^8.1.0",
"eslint-config-prettier": "^8.3.0",
Expand All @@ -107,11 +105,11 @@
"eslint-plugin-vue": "^9.1.1",
"husky": "^8.0.1",
"hygen": "^6.1.0",
"lint-staged": "^13.0.2",
"prettier": "^2.4.1",
"lint-staged": "^15.2.0",
"prettier": "^2.8.8",
"semantic-release": "^19.0.5",
"vite": "^4.0.0",
"vite-plugin-istanbul": "^2.5.1",
"vite-plugin-istanbul": "^5.0.0",
"vue": "^3.2.33",
"vue-loader": "^17.0.0",
"vue-router": "^4.0.12"
Expand Down
8 changes: 5 additions & 3 deletions playground/tree-shaking/src/components/HelloWorld.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<script setup>
defineProps({
// Un-used `props` variable needed for code coverage to be instrumented.
// eslint-disable-next-line no-unused-vars
const props = defineProps({
msg: {
type: String,
required: true
}
required: true,
},
})
</script>

Expand Down
4 changes: 3 additions & 1 deletion src/components/BaseHeading/BaseHeading.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<script setup>
defineProps({
// Un-used `props` variable needed for code coverage to be instrumented.
// eslint-disable-next-line no-unused-vars
const props = defineProps({
tag: {
type: String,
default: 'h2',
Expand Down
4 changes: 3 additions & 1 deletion src/components/UsaChecklist/UsaChecklist.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<script setup>
import UsaChecklistItem from '@/components/UsaChecklistItem'

defineProps({
// Un-used `props` variable needed for code coverage to be instrumented.
// eslint-disable-next-line no-unused-vars
const props = defineProps({
items: {
type: Array,
default: () => [],
Expand Down
4 changes: 3 additions & 1 deletion src/components/UsaCollectionHeading/UsaCollectionHeading.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
import BaseHeading from '@/components/BaseHeading'
import BaseLink from '@/components/BaseLink'

defineProps({
// Un-used `props` variable needed for code coverage to be instrumented.
// eslint-disable-next-line no-unused-vars
const props = defineProps({
href: {
type: String,
default: '',
Expand Down
4 changes: 3 additions & 1 deletion src/components/UsaCollectionItem/UsaCollectionItem.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<script setup>
import UsaCollectionHeading from '@/components/UsaCollectionHeading'

defineProps({
// Un-used `props` variable needed for code coverage to be instrumented.
// eslint-disable-next-line no-unused-vars
const props = defineProps({
heading: {
type: String,
default: '',
Expand Down
4 changes: 3 additions & 1 deletion src/components/UsaCollectionMeta/UsaCollectionMeta.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<script setup>
defineProps({
// Un-used `props` variable needed for code coverage to be instrumented.
// eslint-disable-next-line no-unused-vars
const props = defineProps({
ariaLabel: {
type: String,
required: true,
Expand Down
4 changes: 2 additions & 2 deletions src/components/UsaDatePicker/UsaDatePicker.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ describe('UsaDatePicker', () => {

cy.get('div.usa-date-picker__calendar')
.as('calendar')
.should('have.attr', 'role', 'dialog')
.and('have.attr', 'aria-modal', 'true')
.should('have.attr', 'role', 'application')
.and('have.attr', 'data-value', '')
.and('have.attr', 'hidden', 'hidden')
.and('have.attr', 'style')
cy.get('@calendar').should('not.have.attr', 'aria-modal')

cy.get('div.usa-date-picker__status')
.as('status')
Expand Down
4 changes: 2 additions & 2 deletions src/components/UsaDatePicker/UsaDatePicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,11 @@ const props = defineProps({
},
yearSelectionButtonLabel: {
type: String,
default: '%s. Click to select year',
default: '%s. Select year',
},
monthSelectionButtonLabel: {
type: String,
default: '%s. Click to select month',
default: '%s. Select month',
},
previousYearsButtonLabel: {
type: String,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('UsaDatePickerCalendar', () => {
.as('wrapper')

cy.get('.usa-date-picker__calendar')
.should('have.attr', 'role', 'dialog')
.should('have.attr', 'role', 'application')
.and('have.attr', 'data-value', '2022-07-13')
.and('not.have.attr', 'hidden', 'true')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ onMounted(() => {
<div
ref="calendarPickerRef"
class="usa-date-picker__calendar"
role="dialog"
aria-modal="true"
role="application"
:data-value="highlightedDate"
:hidden="!open"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,15 @@ describe('UsaDatePickerCalendarDay', () => {
.and('be.empty')

cy.get('table.usa-date-picker__calendar__table').should(
'have.attr',
'role',
'presentation'
'not.have.attr',
'role'
)

cy.get('.usa-date-picker__calendar__table > thead > tr')
.children()
.should('have.length', 7)
.and('have.class', 'usa-date-picker__calendar__day-of-week')
.and('have.attr', 'scope', 'presentation')
.and('have.attr', 'scope', 'col')

cy.get('.usa-date-picker__calendar__table th:nth-of-type(1)')
.should('have.attr', 'aria-label', 'Sunday')
Expand Down Expand Up @@ -1710,18 +1709,18 @@ describe('UsaDatePickerCalendarDay', () => {
})

// Make sure the next tab element has been initially rendered.
// cy.get('.usa-date-picker__calendar__previous-year').should('not.have.focus')
// cy.get('.usa-date-picker__calendar__previous-month').should(
// 'not.have.focus'
// )
// cy.get('.usa-date-picker__calendar__month-selection').should(
// 'not.have.focus'
// )
// cy.get('.usa-date-picker__calendar__year-selection').should(
// 'not.have.focus'
// )
// cy.get('.usa-date-picker__calendar__next-month').should('not.have.focus')
// cy.get('.usa-date-picker__calendar__next-year').should('not.have.focus')
cy.get('.usa-date-picker__calendar__previous-year').should('not.have.focus')
cy.get('.usa-date-picker__calendar__previous-month').should(
'not.have.focus'
)
cy.get('.usa-date-picker__calendar__month-selection').should(
'not.have.focus'
)
cy.get('.usa-date-picker__calendar__year-selection').should(
'not.have.focus'
)
cy.get('.usa-date-picker__calendar__next-month').should('not.have.focus')
cy.get('.usa-date-picker__calendar__next-year').should('not.have.focus')

// Should start on selected date: 2022-07-13.
cy.get('button[data-value="2022-07-13"]')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -495,14 +495,14 @@ onBeforeUnmount(() => {
</div>
</div>

<table class="usa-date-picker__calendar__table" role="presentation">
<table class="usa-date-picker__calendar__table">
<thead>
<tr>
<th
v-for="(dayLabel, index) in dayOfWeekLabels"
:key="dayLabel"
class="usa-date-picker__calendar__day-of-week"
scope="presentation"
scope="col"
:aria-label="dayLabel"
>{{ dayOfWeekAbbreviationLabels[index] }}
</th>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,15 @@ describe('UsaDatePickerCalendarYear', () => {
'-1'
)

cy.get('.usa-date-picker__calendar__year-picker > table')
.should('have.attr', 'role', 'presentation')
.and('have.class', 'usa-date-picker__calendar__table')
cy.get('.usa-date-picker__calendar__year-picker > table').should(
'have.class',
'usa-date-picker__calendar__table'
)

cy.get('.usa-date-picker__calendar__year-picker > table').should(
'not.have.attr',
'role'
)

cy.get('.usa-date-picker__calendar__year-picker > table > tbody').should(
'exist'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ onBeforeUnmount(() => {
tabindex="-1"
class="usa-date-picker__calendar__year-picker"
>
<table role="presentation" class="usa-date-picker__calendar__table">
<table class="usa-date-picker__calendar__table">
<tbody>
<tr>
<td>
Expand Down
Loading
Loading