fix(UsaRange): remove redundant ARIA attributes

patrickcate · Dec 17, 2023 · f1650d6 · f1650d6
1 parent b38a2c4
commit f1650d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 17 deletions.
diff --git a/src/components/UsaRange/UsaRange.test.js b/src/components/UsaRange/UsaRange.test.js
@@ -19,19 +19,13 @@ describe('UsaRange', () => {
     cy.get('div.usa-form-group').should('not.have.attr', 'name')
     cy.get('label.usa-label').should('have.attr', 'for')
 
-    cy.get('input.usa-range').as('range').should('have.attr', 'id')
-    cy.get('@range')
-      .should('have.attr', 'name')
-      .and('contain', 'test-dropdown-name')
-    cy.get('@range').should('have.attr', 'type').and('contain', 'range')
-    cy.get('@range').should('have.attr', 'role').and('contain', 'slider')
-    cy.get('@range').should('have.attr', 'min').and('contain', 0)
-    cy.get('@range').should('have.attr', 'aria-valuemin').and('contain', 0)
-    cy.get('@range').should('have.attr', 'max').and('contain', 100)
-    cy.get('@range').should('have.attr', 'aria-valuemax').and('contain', 100)
-    cy.get('@range').should('have.attr', 'aria-valuenow').and('contain', '')
-
-    cy.get('@range').should('have.attr', 'aria-describedby')
+    cy.get('input.usa-range').should('have.attr', 'id')
+    cy.get('input.usa-range')
+      .should('have.attr', 'name', 'test-dropdown-name')
+      .and('have.attr', 'type', 'range')
+      .and('have.attr', 'min', 0)
+      .and('have.attr', 'max', 100)
+      .and('have.attr', 'aria-describedby')
   })
 
   it('displays `label`, `hint`, and `error-message` slot content', () => {

diff --git a/src/components/UsaRange/UsaRange.vue b/src/components/UsaRange/UsaRange.vue
@@ -118,12 +118,8 @@ const ariaDescribedby = computed(() => {
       class="usa-range"
       :class="classes"
       type="range"
-      role="slider"
       :min="min"
       :max="max"
-      :aria-valuemin="min"
-      :aria-valuemax="max"
-      :aria-valuenow="rangeValue"
       :required="required"
       :aria-describedby="ariaDescribedby"
     />