feat: allow component level routerComponentName prop to be an object

This is needed to allow for component instances of link components link `NuxtLink` to be used.
patrickcate · Feb 22, 2024 · 5ddadab · 5ddadab
1 parent 9e6a103
commit 5ddadab
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 11 deletions.
diff --git a/src/components/BaseLink/BaseLink.vue b/src/components/BaseLink/BaseLink.vue
@@ -20,7 +20,7 @@ export default {
       default: '',
     },
     routerComponentName: {
-      type: String,
+      type: [String, Object],
       default: '',
     },
   },

diff --git a/src/components/UsaBreadcrumbItem/UsaBreadcrumbItem.vue b/src/components/UsaBreadcrumbItem/UsaBreadcrumbItem.vue
@@ -12,7 +12,7 @@ const props = defineProps({
     default: '',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
   current: {

diff --git a/src/components/UsaCollectionHeading/UsaCollectionHeading.vue b/src/components/UsaCollectionHeading/UsaCollectionHeading.vue
@@ -14,7 +14,7 @@ const props = defineProps({
     default: '',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
   headingTag: {

diff --git a/src/components/UsaCollectionItem/UsaCollectionItem.vue b/src/components/UsaCollectionItem/UsaCollectionItem.vue
@@ -21,7 +21,7 @@ const props = defineProps({
     default: '',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
   customClasses: {

diff --git a/src/components/UsaIdentifierLogo/UsaIdentifierLogo.vue b/src/components/UsaIdentifierLogo/UsaIdentifierLogo.vue
@@ -13,7 +13,7 @@ const props = defineProps({
     default: '',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
   src: {

diff --git a/src/components/UsaLogo/UsaLogo.vue b/src/components/UsaLogo/UsaLogo.vue
@@ -17,7 +17,7 @@ const props = defineProps({
     default: '/',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
   customClasses: {

diff --git a/src/components/UsaNavPrimaryItem/UsaNavPrimaryItem.vue b/src/components/UsaNavPrimaryItem/UsaNavPrimaryItem.vue
@@ -23,7 +23,7 @@ const props = defineProps({
     default: '',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
 })

diff --git a/src/components/UsaNavSubmenuItem/UsaNavSubmenuItem.vue b/src/components/UsaNavSubmenuItem/UsaNavSubmenuItem.vue
@@ -24,7 +24,7 @@ const props = defineProps({
     default: '',
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: '',
   },
 })

diff --git a/src/components/UsaPaginationArrow/UsaPaginationArrow.vue b/src/components/UsaPaginationArrow/UsaPaginationArrow.vue
@@ -30,7 +30,7 @@ const props = defineProps({
     default: undefined,
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: undefined,
   },
   customClasses: {

diff --git a/src/components/UsaPaginationItem/UsaPaginationItem.vue b/src/components/UsaPaginationItem/UsaPaginationItem.vue
@@ -27,7 +27,7 @@ const props = defineProps({
     default: undefined,
   },
   routerComponentName: {
-    type: String,
+    type: [String, Object],
     default: undefined,
   },
 })

diff --git a/src/components/UsaTooltip/UsaTooltip.vue b/src/components/UsaTooltip/UsaTooltip.vue
@@ -104,6 +104,7 @@ watch(isSet, currentlySet => {
       isVisible.value = currentlySet
       // May be able to be removed once:
       // https://github.com/uswds/uswds/issues/4458 is fixed.
+      // @deprecated if issue is fixed.
       currentCoordinates.value.opacity = currentlySet ? 1 : 0
     })
   })
@@ -113,7 +114,8 @@ onMounted(() => {
   // `isSet` needs to be `true` until floating UI has initialized and has
   // calculated it's initial position.
   // May be able to be removed once:
-  //  https://github.com/uswds/uswds/issues/4458 is fixed.
+  // https://github.com/uswds/uswds/issues/4458 is fixed.
+  // @deprecated if issue is fixed.
   isSet.value = true
 
   cleanupFloatingUi = autoUpdate(