Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bold and italic on the same line breaks #6

Closed
xdamman opened this issue Feb 1, 2018 · 3 comments · Fixed by #8
Closed

bold and italic on the same line breaks #6

xdamman opened this issue Feb 1, 2018 · 3 comments · Fixed by #8

Comments

@xdamman
Copy link

xdamman commented Feb 1, 2018

This looks like a very cool plugin.
Running into a few annoying issues though that prevent me from using this on prod:

On the demo: https://patleeman.github.io/quill-markdown-shortcuts/

If you type

**bold** *italic*

It will turn the entire line into italic.
Also, unable to get out of a fenced code block. Even after clicking on remove all styles.

See:

@patleeman
Copy link
Owner

Thanks for pointing these out, I will take a look at these corner cases

@patleeman
Copy link
Owner

Oh this is interesting, it doesn't happen if you hit enter but it does if you hit space.

patleeman added a commit that referenced this issue Feb 22, 2018
This commit resolves issue # 6 (#6).
It also fixes bold italic not rendering properly.
@patleeman
Copy link
Owner

Looking at these discussions:

slab/quill#1228

slab/quill#954

It seems like Quill's removeFormat doesn't clear block formats without a selected range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants