Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default for lifetimeDays #61

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Set a default for lifetimeDays #61

merged 1 commit into from
Dec 23, 2024

Conversation

andyleiserson
Copy link
Collaborator

Resolves #45

martinthomson
martinthomson approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick the most sensible default. There is no one true default here, but this seems fine to me.

@martinthomson martinthomson merged commit 405eb17 into main Dec 23, 2024
1 check passed
@andyleiserson andyleiserson deleted the default-lifetime branch January 3, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set a default for lifetimeDays
2 participants
@andyleiserson @martinthomson