Do not replace <- with = if within a function call since it has other…

… meaning.
pat-s · May 12, 2019 · 5bf20ab · 5bf20ab
1 parent 463100f
commit 5bf20ab
Show file tree

Hide file tree

Showing 6 changed files with 302 additions and 260 deletions.
diff --git a/R/rules-replacement.R b/R/rules-replacement.R
@@ -7,8 +7,10 @@ force_assignment_op <- function(pd) {
 
 force_assignment_eq <- function(pd) {
   to_replace <- pd$token == "LEFT_ASSIGN" & pd$text == "<-"
-  pd$token[to_replace] <- "EQ_ASSIGN"
-  pd$text[to_replace] <- "="
+  if (any(to_replace) && next_terminal(pd)$token == "'('") {
+    pd$token[to_replace] <- "EQ_ASSIGN"
+    pd$text[to_replace] <- "="
+  }
   pd
 }
 

diff --git a/tests/testthat/mlr-style/eq-sub-replacement-in.R b/tests/testthat/mlr-style/eq-sub-replacement-in.R
@@ -0,0 +1,3 @@
+c(a <- 3)
+(a = b)
+((a = 3))
diff --git a/tests/testthat/mlr-style/eq-sub-replacement-in_tree b/tests/testthat/mlr-style/eq-sub-replacement-in_tree
diff --git a/tests/testthat/mlr-style/eq-sub-replacement-out.R b/tests/testthat/mlr-style/eq-sub-replacement-out.R
@@ -0,0 +1,3 @@
+c(a <- 3)
+(a = b)
+((a = 3))