Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes #5

Merged
merged 3 commits into from
Aug 27, 2016
Merged

Various changes #5

merged 3 commits into from
Aug 27, 2016

Conversation

danmichaelo
Copy link
Contributor

@danmichaelo danmichaelo commented Aug 13, 2016

  • Use escapeshellarg by default, but allow disabling it.
  • Use custom exceptions: InvalidArgumentException for the invalid argument case, and
    introduce a new CommandException class for the rest.
  • Merge stderr with stdout by default (to avoid stderr leaking out like "sh: 1: echo111: not found" does here: https://travis-ci.org/pastuhov/php-exec-command/jobs/152053935)

@danmichaelo danmichaelo changed the title Use escapeshellarg Various changes Aug 13, 2016
Use escapeshellarg by default, but allow disabling it.
Use InvalidArgumentException for the invalid argument case, and
introduce a new CommandException class for the rest.
Redirect stderr to stdout to have it included in output by default.
@pastuhov pastuhov merged commit 5c7a718 into pastuhov:master Aug 27, 2016
@pastuhov
Copy link
Owner

thanks!

@Rpsl
Copy link

Rpsl commented Sep 6, 2016

Use escapeshellarg by default, but allow disabling it.
Достаточно мажорное исправление которое ломает обратную совместимость, по возможности, в следующий раз, делайте для таких апдейтов новую мажорную версию. Например 2.0
Спасибо.

@pastuhov
Copy link
Owner

pastuhov commented Sep 7, 2016

Согласен, будем делать, спасибо )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants