Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64Url Id instead of byte[] #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Regenhardt
Copy link
Contributor

@Regenhardt Regenhardt commented Dec 30, 2024

#513

Not sure if any of the places that now use RawId should be changed to use Id instead, like CredentialId being returned from a successful assertion. This basically just changes the model and makes everything use the RawId, so minimal breaking changes hopefully.

RawId is decoded to the raw byte value, while Id is the same value in base64url-encoded form.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (b7f1735) to head (61e2694).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         101      101           
  Lines        2600     2600           
  Branches      432      432           
=======================================
  Hits         1977     1977           
  Misses        513      513           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs abergs self-requested a review January 10, 2025 16:10
Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been reviewing this, as well has reading some of the related WebAuthn discussions. like: w3c/webauthn#2119

Although this will introduce lots of "won't-compile"-errors when people upgrade to 4.0, I agree it's probably the right thing to do.

The current set of changes look good, however I think we also need to change the Id-prop on AuthenticatorAttestationRawResponse, so I will request changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants