(PC-34594)[API] refactor: rework favorites to avoid using join-tables… #16310
+68
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +26,8 @@ def post_collective_offer_favorites(authenticated_information: AuthenticatedInfo | |||
| if redactor is None: | |||
| raise ApiErrors({"message": "Redactor not found"}, status_code=403) | |||
|
|
|||
| educational_api.add_offer_to_favorite_adage(redactor_id=redactor.id, offer_id=offer.id) | |||
| redactor.favoriteCollectiveOffers.append(offer) | |||
There was a problem hiding this comment.
Il se passe quoi si l'offre est déjà dans favoriteCollectiveOffers ? Pas grand chose I guess ?
| educational_models.CollectiveOfferEducationalRedactor.query.filter_by( | ||
| educationalRedactorId=redactor.id, collectiveOfferId=offer_id | ||
| ).delete(synchronize_session=False) | ||
| redactor.favoriteCollectiveOffers.remove(offer) |
There was a problem hiding this comment.
Est ce que ça fait une erreur si offer n'est pas dans favoriteCollectiveOffers ?
| return serializers.ListCollectiveOfferTemplateResponseModel( | ||
| collectiveOffers=[ | ||
| typing.cast( | ||
| serializers.CollectiveOfferTemplateResponseModel, | ||
| serialize_collective_offer( | ||
| offer=item.collective_offer_template, | ||
| serializer=serializers.CollectiveOfferTemplateResponseModel, | ||
| is_favorite=item.collective_offer_template.id in favorite_ids, | ||
| is_favorite=item.collective_offer_template in redactor.favoriteCollectiveOfferTemplates, |
There was a problem hiding this comment.
Ptet un petit selectinload ou quoi sur favoriteCollectiveOfferTemplates dans find_redactor_by_email, j'imagine que tous les 'offer in redactor.favorites' vont faire des requêtes en plus en l'état
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in queries
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34594
Vérifications