Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-34592)[API] refactor: split Algolia indexing concepts appart #16307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(PC-34592)[API] refactor: split Algolia indexing concepts appart #16307

wants to merge 2 commits into from

Conversation

xordoquy-pass
Copy link
Contributor

The AlgoliaBackend used to index offers to Algolia had too many concepts embedded within:

  • the communication with Algolia
  • the Redis queues and hashmaps management
  • the object's serialization

This commit split those 3 area into different parts.

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34592

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

@xordoquy-pass xordoquy-pass marked this pull request as draft February 12, 2025 16:27
@xordoquy-pass xordoquy-pass force-pushed the PC-34592-preparation-upgrade-majeure-algolia-en-4-x branch from d3a2729 to 22bf0b3 Compare February 12, 2025 16:56
@xordoquy-pass
(PC-34592)[API] refactor: split Algolia indexing concepts appart
25192f9 
The AlgoliaBackend used to index offers to Algolia had too many
concepts embedded within:
- the communication with Algolia
- the Redis queues and hashmaps management
- the object's serialization

This commit split those 3 area into different parts.
@xordoquy-pass
(PC-34592)[API] refactor: don't use models in the redis queues manage…
7132809 
…ment
@xordoquy-pass xordoquy-pass force-pushed the PC-34592-preparation-upgrade-majeure-algolia-en-4-x branch from 22bf0b3 to 7132809 Compare February 13, 2025 08:06
@xordoquy-pass xordoquy-pass marked this pull request as ready for review February 13, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xordoquy-pass