(PC-34142)[API] fix: edit stock: compare dates without tz #16245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a stock, the existing and the new beginning times were compared but could never be equal since the first does not have any TZ information (datetime is saved without it inside the DB) and the later does. Now, to find out if the beginning date needs to be updated, the check is performed with two TZ-unaware datetime objects. Of course, this should not be needed: the real fix is to save the TZ inside the database. So please, please, please Let me, let me, let me Let me get the timezones that I want This time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34142
Fix rapide concernant la mise à jour des stocks.
Avant
Impossible de détecter que la nouvelle date et l'actuelle sont en fait les mêmes : celle qui vient de la base de données n'a pas d'information de fuseau horaire, le paramètre d'entrée de la fonction l'a.
Après
On retire l'information du fuseau horaire le temps de comparer les deux dates avant de déterminer s'il y a eu un changement à ce niveau-là.