Pc 32824 retention design fixes #16231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 526e7e8): https://pc-pro-testing--pr16231-pc-32824-retention-d-udvs6a82.web.app (expires Sat, 15 Feb 2025 09:24:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
2 times, most recently
from
d546694 to
68e7c9a
Compare
abouabdallaoui-pass
approved these changes
Feb 11, 2025
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
from
97748a9 to
454a44a
Compare
rchaffal-pass
approved these changes
Feb 11, 2025
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
4 times, most recently
from
90342ff to
b298789
Compare
mleroy-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
8 times, most recently
from
566c52d to
8963b97
Compare
mleroy-pass
approved these changes
Feb 11, 2025
mleroy-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
from
8963b97 to
62b33ad
Compare
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
2 times, most recently
from
f5b75d4 to
cc511a7
Compare
mleroy-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
6 times, most recently
from
8667475 to
f21cd44
Compare
mleroy-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
4 times, most recently
from
2003280 to
c31ec7e
Compare
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
2 times, most recently
from
bea922e to
f00c6ec
Compare
mleroy-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
6 times, most recently
from
3cf86b3 to
b648b12
Compare
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
from
b648b12 to
ac7d5b7
Compare
gmeigniez-pass
force-pushed
the
pc-32824-retention-design-fixes
branch
from
ac7d5b7 to
526e7e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32824
Objectif
2 corrections d'irritant design, et 1 ajout de tracker :
L'alignement des boutons d'action de synchro des providers : avant/après
Déplacement du callout de modif d'email : avant/après
Garder le gap entre les form layout row items (petits écrans) avant/après
Vérifications