PC-34428 BSR pro shard strategy #16221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleroy-pass
force-pushed
the
PC-34428-BSR-PRO-shard-strategy
branch
from
c25b9b6 to
91eadaa
Compare
|
Visit the preview URL for this PR (updated for commit b344e38): https://pc-pro-testing--pr16221-pc-34428-bsr-pro-sha-efuqbh54.web.app (expires Sun, 09 Feb 2025 09:27:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
mlachevre-pass
approved these changes
Feb 6, 2025
mleroy-pass
force-pushed
the
PC-34428-BSR-PRO-shard-strategy
branch
from
91eadaa to
bfd6f05
Compare
fseguin-pass
reviewed
Feb 6, 2025
| @@ -218,7 +218,7 @@ jobs: | |||
| GCP_EHP_WORKLOAD_IDENTITY_PROVIDER: ${{ secrets.GCP_EHP_WORKLOAD_IDENTITY_PROVIDER }} | |||
|
|
|||
| test-pro: | |||
| name: "Tests pro" | |||
| name: "Units Tests" | |||
There was a problem hiding this comment.
Suggested change
| name: "Units Tests" | |
| name: "Pro Units Tests" |
fseguin-pass
approved these changes
Feb 6, 2025
| @@ -215,7 +215,7 @@ jobs: | |||
| GCP_EHP_WORKLOAD_IDENTITY_PROVIDER: ${{ secrets.GCP_EHP_WORKLOAD_IDENTITY_PROVIDER }} | |||
|
|
|||
| test-pro: | |||
| name: "Tests pro" | |||
| name: "Units Tests" | |||
There was a problem hiding this comment.
Suggested change
| name: "Units Tests" | |
| name: "Pro Units Tests" |
| @@ -47,32 +42,26 @@ jobs: | |||
| - run: yarn lint:js | |||
| - run: yarn lint:scss | |||
|
|
|||
| tests-pro-unit-tests: | |||
| run-tests: | |||
| @@ -47,32 +42,26 @@ jobs: | |||
| - run: yarn lint:js | |||
| - run: yarn lint:scss | |||
|
|
|||
| tests-pro-unit-tests: | |||
| run-tests: | |||
| name: "Unit tests" | |||
There was a problem hiding this comment.
Suggested change
| name: "Unit tests" | |
| name: "Pro Unit tests" |
mleroy-pass
force-pushed
the
PC-34428-BSR-PRO-shard-strategy
branch
2 times, most recently
from
5caf59f to
b344e38
Compare
mleroy-pass
force-pushed
the
PC-34428-BSR-PRO-shard-strategy
branch
from
b344e38 to
61f4738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34428
Vérifications