Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33248)[API] feat: Venue with siret or open to public are permanent when created, only when FF WIP_IS_OPEN_TO_PUBLIC is activated #16196

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

pcharlet-pass
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33248

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Visit the preview URL for this PR (updated for commit 5e24dd2):

https://pc-pro-testing--pr16196-pcharlet-pc-33248-pe-xtpipctg.web.app

(expires Sat, 08 Feb 2025 11:28:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@pcharlet-pass pcharlet-pass force-pushed the pcharlet/pc-33248-permanent-venue-on-create branch 2 times, most recently from 8701577 to d4719cd Compare February 6, 2025 11:10
Comment on lines 164 to 165
init_data = self.base_data(user_offerer.offerer) | {"siret": None, "comment": "no siret"}
init_data["isOpenToPublic"] = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce n'est pas possible de faire quelque chose comme ça ?

Suggested change
init_data = self.base_data(user_offerer.offerer) | {"siret": None, "comment": "no siret"}
init_data["isOpenToPublic"] = False
init_data = self.base_data(user_offerer.offerer) | {"siret": None, "comment": "no siret", "isOpenToPublic": False}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si en effet, et c'est beaucoup plus propre !

…t when created, only when FF WIP_IS_OPEN_TO_PUBLIC is activated
@pcharlet-pass pcharlet-pass force-pushed the pcharlet/pc-33248-permanent-venue-on-create branch from d4719cd to 5e24dd2 Compare February 6, 2025 11:25
@pcharlet-pass pcharlet-pass merged commit 30c8a9d into master Feb 6, 2025
27 checks passed
@pcharlet-pass pcharlet-pass deleted the pcharlet/pc-33248-permanent-venue-on-create branch February 6, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants