Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-34041)[API] feat: Add sandbox cases for collectives offers - EAC #16171

Merged
merged 1 commit into from
Feb 7, 2025
Merged

(PC-34041)[API] feat: Add sandbox cases for collectives offers - EAC #16171

merged 1 commit into from
Feb 7, 2025

Conversation

rprasquier-pass
Copy link
Contributor

@rprasquier-pass rprasquier-pass commented Feb 4, 2025 •
edited
Loading

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34041

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

@rprasquier-pass rprasquier-pass changed the title (PC-34041)[API] feat: Add sandbox case (PC-34041)[API] feat: Add sandbox cases Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Visit the preview URL for this PR (updated for commit 87a7f4c):

https://pc-pro-testing--pr16171-pc-34041-eac-back-cr-r8o76dsa.web.app

(expires Thu, 06 Feb 2025 15:10:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@rprasquier-pass rprasquier-pass changed the title (PC-34041)[API] feat: Add sandbox cases (PC-34041)[API] feat: Add sandbox cases for collectives offers - EAC Feb 4, 2025
@rprasquier-pass rprasquier-pass force-pushed the PC-34041-eac-back-creer-le-scenario-de-tests-dans-la-sandbox branch 2 times, most recently from 4f6ecdb to 2121d3a Compare February 6, 2025 15:57
jcicurel-pass
jcicurel-pass reviewed Feb 6, 2025
View reviewed changes
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Outdated Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Outdated Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Outdated Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Outdated Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Outdated Show resolved Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py Show resolved Hide resolved
@rprasquier-pass rprasquier-pass force-pushed the PC-34041-eac-back-creer-le-scenario-de-tests-dans-la-sandbox branch from 2121d3a to c1af1a4 Compare February 6, 2025 16:56
@rprasquier-pass rprasquier-pass force-pushed the PC-34041-eac-back-creer-le-scenario-de-tests-dans-la-sandbox branch 2 times, most recently from 988de0c to 19f6e75 Compare February 7, 2025 09:46
@rprasquier-pass rprasquier-pass force-pushed the PC-34041-eac-back-creer-le-scenario-de-tests-dans-la-sandbox branch from 19f6e75 to 18fbd94 Compare February 7, 2025 10:06
jcicurel-pass
jcicurel-pass approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jcicurel-pass jcicurel-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👌

@rprasquier-pass rprasquier-pass merged commit 8ff8724 into master Feb 7, 2025
25 checks passed
@rprasquier-pass rprasquier-pass deleted the PC-34041-eac-back-creer-le-scenario-de-tests-dans-la-sandbox branch February 7, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcicurel-pass jcicurel-pass jcicurel-pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rprasquier-pass @jcicurel-pass