(PC-32840)[API] feat: prevent young users from using ineligible postal codes #15714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 98fd6c4): https://pc-pro-testing--pr15714-pc-32840-exclude-nor-tgn59xuw.web.app (expires Thu, 23 Jan 2025 08:57:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
dnguyen-pass
force-pushed
the
PC-32840-exclude-north-caledonia
branch
2 times, most recently
from
f5af68c to
cd68326
Compare
dnguyen-pass
temporarily deployed
to
pullrequest
GitHub Actions
Inactive
dnguyen-pass
force-pushed
the
PC-32840-exclude-north-caledonia
branch
from
cd68326 to
fa45a5c
Compare
dnguyen-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
dnguyen-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
prouzet-pass
reviewed
Jan 8, 2025
api/src/pcapi/utils/postal_code.py
Outdated
Comment on lines
15
to
32
| NORTH_CALEDONIAN_POSTAL_CODES = { | ||
| "98811": "Bélep", | ||
| "98813": "Canala", | ||
| "98815": "Hienghène", | ||
| "98816": "Houaïlou", | ||
| "98817": "Kaala-Gomen", | ||
| "98818": "Kouaoua", | ||
| "98821": "Ouégoa", | ||
| "98822": "Poindimié", | ||
| "98823": "Ponérihouen", | ||
| "98824": "Pouébo", | ||
| "98825": "Pouembout", | ||
| "98826": "Poum", | ||
| "98831": "Touho", | ||
| "98833": "Voh", | ||
| "98850": "Koumac", | ||
| "98860": "Koné", | ||
| } |
There was a problem hiding this comment.
Une collection des seuls codes postaux ne serait-elle pas suffisante ? A priori on n'utilise nulle part le nom de la commune.
dnguyen-pass
force-pushed
the
PC-32840-exclude-north-caledonia
branch
from
fa45a5c to
df33462
Compare
cnormant-pass
approved these changes
Jan 20, 2025
| account_creation_minimum_age: int | ||
| account_unsuspension_limit: int |
There was a problem hiding this comment.
Quel rapport avec cette PR ?
There was a problem hiding this comment.
erreur de rebase avec le tri des clés :'(
dnguyen-pass
force-pushed
the
PC-32840-exclude-north-caledonia
branch
from
df33462 to
10dcdff
Compare
tconte-pass
approved these changes
Jan 20, 2025
dnguyen-pass
force-pushed
the
PC-32840-exclude-north-caledonia
branch
4 times, most recently
from
e7a896c to
a43b774
Compare
dnguyen-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
Comment on lines
73
to
76
| if ( | ||
| "postal_code" in profile_update_dict | ||
| and profile_update_dict["postal_code"] in postal_code_utils.INELIGIBLE_POSTAL_CODES | ||
| ): |
There was a problem hiding this comment.
Détail : proposition plus simple :
Suggested change
| if ( | |
| "postal_code" in profile_update_dict | |
| and profile_update_dict["postal_code"] in postal_code_utils.INELIGIBLE_POSTAL_CODES | |
| ): | |
| if profile_update_dict.get("postal_code") in postal_code_utils.INELIGIBLE_POSTAL_CODES: |
api/src/pcapi/utils/postal_code.py
Outdated
| "98850", # Koumac | ||
| "98860", # Koné | ||
| ] | ||
| LOYALTY_ISLAND_POSTAL_CODES = [ |
There was a problem hiding this comment.
Suggested change
| LOYALTY_ISLAND_POSTAL_CODES = [ | |
| LOYALTY_ISLANDS_POSTAL_CODES = [ |
dnguyen-pass
force-pushed
the
PC-32840-exclude-north-caledonia
branch
from
a43b774 to
98fd6c4
Compare
prouzet-pass
approved these changes
Jan 21, 2025
dnguyen-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32840