Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BSR)[PRO] test: timeout 60 secs for request to get email #15170

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

scolson-pass
Copy link
Contributor

@scolson-pass scolson-pass commented Nov 21, 2024

But de la pull request

Dans la route get_unique_email de e2e.py on lit la file d'attente d'email pendant 60 secondes max, il faut donc que le timeout dans l'appel depuis les tests e2e soit le même

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Visit the preview URL for this PR (updated for commit ecd2187):

https://pc-pro-testing--pr15170-scolson-bsr-pro-time-a7pgpcta.web.app

(expires Sun, 15 Dec 2024 10:53:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@scolson-pass scolson-pass marked this pull request as ready for review November 22, 2024 14:27
@scolson-pass scolson-pass force-pushed the scolson/bsr-pro-timeout-get-unique-email branch from 2ca7531 to 6f6066d Compare November 22, 2024 14:30
@scolson-pass scolson-pass force-pushed the scolson/bsr-pro-timeout-get-unique-email branch from 6f6066d to ecd2187 Compare December 13, 2024 10:43
@scolson-pass scolson-pass merged commit dbff2ca into master Dec 13, 2024
20 checks passed
@scolson-pass scolson-pass deleted the scolson/bsr-pro-timeout-get-unique-email branch December 13, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants