Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32494)[API] feat: Don't reuse OffererAddress among managedVenues #14691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damien-ramelet
Copy link
Contributor

For easier filtering on offers, we want distinct offerer_address among managedVenues, even if they use the same address.

With unique offererAddress we would have been forced to filter over offer.offererAddressId and offer.venueId to retrieve offers of a location.
Now, we only have to filter on offer.offererAddressId

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32494

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

For easier filtering on offers, we want distinct offerer_address among
managedVenues, even if they use the same address.

With unique offererAddress we would have been forced to filter over
offer.offererAddressId and offer.venueId to retrieve offers of a
location.
Now, we only have to filter on offer.offererAddressId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant