-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-32511)[PRO] Ajout de donnée sur la sandbox pour gérer tous les cas de displayedStatus #14662
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👌
Le seul truc qui m'embête c'est les CANCELLED, où on mélange les auto-cancel et des cancel manuels, mais on ne voit pas la différence en regardant seulement le statut des objets
Aussi si tu as besoin de regarder la raison d'annulation il faudra le préciser sur ces objets (à faire dans un second temps si besoin peut être)
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_venues.py
Show resolved
Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py
Outdated
Show resolved
Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py
Show resolved
Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py
Outdated
Show resolved
Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py
Show resolved
Hide resolved
api/src/pcapi/sandboxes/scripts/creators/industrial/create_industrial_eac_data/create_offers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pourquoi reimbursementPoint dans le name ?
C'est un des lieux utilisé pour le remboursement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
détail : je l'appellerais pas
corner_cases
parce qu'il y a tous les cas dedans,_different_status_list
ou qq chose comme ça ?
Il n'y a pas tout les cas, mais je prends le point
f33fe64
to
dafa132
Compare
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32511
L'ensemble des cas se trouve sur le document : https://docs.google.com/spreadsheets/d/1yQvw2AA_PxlDtHRmFbB6ORmuSfCoN5-HXVd5sIn465g/edit?pli=1&gid=0#gid=0
Vérifications