Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32489)[API] feat: change db constraint to allow multiple identica… #14658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

(PC-32489)[API] feat: change db constraint to allow multiple identica…

2466987
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

(PC-32489)[API] feat: change db constraint to allow multiple identica… #14658

(PC-32489)[API] feat: change db constraint to allow multiple identica…
2466987
Select commit
Loading
Failed to load commit list.
GitHub Actions / Pytest Report failed Oct 21, 2024 in 0s

2625 tests run, 2621 passed, 1 skipped, 3 failed.

Annotations

Check failure on line 201 in tests/routes/pro/patch_offer_test.py

See this annotation in the file changed.

@github-actions github-actions / Pytest Report

tests/routes/pro/patch_offer_test.py.test_patch_offer_with_address[None-True-True]

AssertionError: {'global': ['Il semble que nous ayons des problèmes techniques :( On répare ça au plus vite.']}
assert 500 == 200
 +  where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code
Raw output
tests/routes/pro/patch_offer_test.py:269: in test_patch_offer_with_address
    assert response.status_code == 200, response.json
E   AssertionError: {'global': ['Il semble que nous ayons des problèmes techniques :( On répare ça au plus vite.']}
E   assert 500 == 200
E    +  where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code

Check failure on line 201 in tests/routes/pro/patch_offer_test.py

See this annotation in the file changed.

@github-actions github-actions / Pytest Report

tests/routes/pro/patch_offer_test.py.test_patch_offer_with_address[None-False-True]

AssertionError: {'global': ['Il semble que nous ayons des problèmes techniques :( On répare ça au plus vite.']}
assert 500 == 200
 +  where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code
Raw output
tests/routes/pro/patch_offer_test.py:269: in test_patch_offer_with_address
    assert response.status_code == 200, response.json
E   AssertionError: {'global': ['Il semble que nous ayons des problèmes techniques :( On répare ça au plus vite.']}
E   assert 500 == 200
E    +  where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code

Check failure on line 287 in tests/routes/pro/test_offerers_addresses.py

See this annotation in the file changed.

@github-actions github-actions / Pytest Report

tests/routes/pro/test_offerers_addresses.py.test_create_offerer_address_with_existing_offerer_address_and_without_label

Failed: 10 queries executed, 7 expected
Captured queries were:
1. SELECT user_session.id AS user_session_id, user_session."userId" AS "user_session_userId", user_session.uuid AS user_session_uuid 
    FROM user_session 
    WHERE user_session."userId" = 1719 AND user_session.uuid = da60d046-a9cc-434f-9c67-9e3280ccba53
2. SELECT "user"."phoneNumber" AS "user_phoneNumber", "user"."isActive" AS "user_isActive", "user".id AS user_id, "user".activity AS user_activity, "user".address AS user_address, "user".city AS user_city, "user".civility AS user_civility, "user".comment AS user_comment, "user"."culturalSurveyFilledDate" AS "user_culturalSurveyFilledDate", "user"."culturalSurveyId" AS "user_culturalSurveyId", "user"."dateCreated" AS "user_dateCreated", "user"."dateOfBirth" AS "user_dateOfBirth", "user"."departementCode" AS "user_departementCode", "user".email AS user_email, "user"."externalIds" AS "user_externalIds", "user"."extraData" AS "user_extraData", "user"."firstName" AS "user_firstName", "user"."hasSeenProTutorials" AS "user_hasSeenProTutorials", "user"."hasSeenProRgs" AS "user_hasSeenProRgs", "user"."idPieceNumber" AS "user_idPieceNumber", "user"."ineHash" AS "user_ineHash", "user"."irisFranceId" AS "user_irisFranceId", "user"."isEmailValidated" AS "user_isEmailValidated", "user"."lastConnectionDate" AS "user_lastConnectionDate", "user"."lastName" AS "user_lastName", "user".married_name AS user_married_name, "user"."needsToFillCulturalSurvey" AS "user_needsToFillCulturalSurvey", "user"."notificationSubscriptions" AS "user_notificationSubscriptions", "user".password AS user_password, "user"."phoneValidationStatus" AS "user_phoneValidationStatus", "user"."postalCode" AS "user_postalCode", "user"."recreditAmountToShow" AS "user_recreditAmountToShow", "user".roles AS user_roles, "user"."schoolType" AS "user_schoolType", "user"."validatedBirthDate" AS "user_validatedBirthDate" 
    FROM "user" 
    WHERE "user".id = 1719
3. SELECT EXISTS (SELECT 1 
    FROM user_offerer 
    WHERE user_offerer."offererId" = 1484 AND user_offerer."userId" = 1719 AND user_offerer."validationStatus" = VALIDATED) AS anon_1
4. ROLLBACK TO SAVEPOINT sa_savepoint_61
5. SELECT address.id AS address_id, address."banId" AS "address_banId", address."inseeCode" AS "address_inseeCode", address.street AS address_street, address."postalCode" AS "address_postalCode", address.city AS address_city, address.latitude AS address_latitude, address.longitude AS address_longitude, address."departmentCode" AS "address_departmentCode", address.timezone AS address_timezone, address."isManualEdition" AS "address_isManualEdition" 
    FROM address 
    WHERE address.street = 3 Rue de Valois AND address."inseeCode" = 75056 AND (address."isManualEdition" IS NOT true OR address."banId" = 75101_9575_00003 AND address."inseeCode" = 75056 AND address.street = 3 Rue de Valois AND address."postalCode" = 75001 AND address.city = Paris AND address.latitude = 48.87171000000000020691004465334117412567138671875 AND address.longitude = 2.308288999999999813184103913954459130764007568359375)
6. INSERT INTO offerer_address (label, "addressId", "offererId") VALUES (None, 1021, 1484) RETURNING offerer_address.id
7. SELECT offerer_address.id AS offerer_address_id, offerer_address.label AS offerer_address_label, offerer_address."addressId" AS "offerer_address_addressId", offerer_address."offererId" AS "offerer_address_offererId", address_1.id AS address_1_id, address_1."banId" AS "address_1_banId", address_1."inseeCode" AS "address_1_inseeCode", address_1.street AS address_1_street, address_1."postalCode" AS "address_1_postalCode", address_1.city AS address_1_city, address_1.latitude AS address_1_latitude, address_1.longitude AS address_1_longitude, address_1."departmentCode" AS "address_1_departmentCode", address_1.timezone AS address_1_timezone, address_1."isManualEdition" AS "address_1_isManualEdition" 
    FROM offerer_address LEFT OUTER JOIN address AS address_1 ON address_1.id = offerer_address."addressId" 
    WHERE offerer_address."offererId" = 1484 AND offerer_address.label IS NULL AND offerer_address."addressId" = 1021
8. ROLLBACK TO SAVEPOINT sa_savepoint_65
9. SELECT address.id AS address_id, address."banId" AS "address_banId", address."inseeCode" AS "address_inseeCode", address.street AS address_street, address."postalCode" AS "address_postalCode", address.city AS address_city, address.latitude AS address_latitude, address.longitude AS address_longitude, address."departmentCode" AS "address_departmentCode", address.timezone AS address_timezone, address."isManualEdition" AS "address_isManualEdition" 
    FROM address 
    WHERE address.id = 1021
10. SELECT offerer_address.id AS offerer_address_id, offerer_address.label AS offerer_address_label, offerer_address."addressId" AS "offerer_address_addressId", offerer_address."offererId" AS "offerer_address_offererId" 
    FROM offerer_address 
    WHERE offerer_address.id = 1319
Raw output
tests/routes/pro/test_offerers_addresses.py:316: in test_create_offerer_address_with_existing_offerer_address_and_without_label
    with assert_num_queries(7):
/usr/local/lib/python3.11/contextlib.py:144: in __exit__
    next(self.gen)
src/pcapi/core/testing.py:82: in assert_num_queries
    pytest.fail(
E   Failed: 10 queries executed, 7 expected
E   Captured queries were:
E   1. SELECT user_session.id AS user_session_id, user_session."userId" AS "user_session_userId", user_session.uuid AS user_session_uuid 
E       FROM user_session 
E       WHERE user_session."userId" = 1719 AND user_session.uuid = da60d046-a9cc-434f-9c67-9e3280ccba53
E   2. SELECT "user"."phoneNumber" AS "user_phoneNumber", "user"."isActive" AS "user_isActive", "user".id AS user_id, "user".activity AS user_activity, "user".address AS user_address, "user".city AS user_city, "user".civility AS user_civility, "user".comment AS user_comment, "user"."culturalSurveyFilledDate" AS "user_culturalSurveyFilledDate", "user"."culturalSurveyId" AS "user_culturalSurveyId", "user"."dateCreated" AS "user_dateCreated", "user"."dateOfBirth" AS "user_dateOfBirth", "user"."departementCode" AS "user_departementCode", "user".email AS user_email, "user"."externalIds" AS "user_externalIds", "user"."extraData" AS "user_extraData", "user"."firstName" AS "user_firstName", "user"."hasSeenProTutorials" AS "user_hasSeenProTutorials", "user"."hasSeenProRgs" AS "user_hasSeenProRgs", "user"."idPieceNumber" AS "user_idPieceNumber", "user"."ineHash" AS "user_ineHash", "user"."irisFranceId" AS "user_irisFranceId", "user"."isEmailValidated" AS "user_isEmailValidated", "user"."lastConnectionDate" AS "user_lastConnectionDate", "user"."lastName" AS "user_lastName", "user".married_name AS user_married_name, "user"."needsToFillCulturalSurvey" AS "user_needsToFillCulturalSurvey", "user"."notificationSubscriptions" AS "user_notificationSubscriptions", "user".password AS user_password, "user"."phoneValidationStatus" AS "user_phoneValidationStatus", "user"."postalCode" AS "user_postalCode", "user"."recreditAmountToShow" AS "user_recreditAmountToShow", "user".roles AS user_roles, "user"."schoolType" AS "user_schoolType", "user"."validatedBirthDate" AS "user_validatedBirthDate" 
E       FROM "user" 
E       WHERE "user".id = 1719
E   3. SELECT EXISTS (SELECT 1 
E       FROM user_offerer 
E       WHERE user_offerer."offererId" = 1484 AND user_offerer."userId" = 1719 AND user_offerer."validationStatus" = VALIDATED) AS anon_1
E   4. ROLLBACK TO SAVEPOINT sa_savepoint_61
E   5. SELECT address.id AS address_id, address."banId" AS "address_banId", address."inseeCode" AS "address_inseeCode", address.street AS address_street, address."postalCode" AS "address_postalCode", address.city AS address_city, address.latitude AS address_latitude, address.longitude AS address_longitude, address."departmentCode" AS "address_departmentCode", address.timezone AS address_timezone, address."isManualEdition" AS "address_isManualEdition" 
E       FROM address 
E       WHERE address.street = 3 Rue de Valois AND address."inseeCode" = 75056 AND (address."isManualEdition" IS NOT true OR address."banId" = 75101_9575_00003 AND address."inseeCode" = 75056 AND address.street = 3 Rue de Valois AND address."postalCode" = 75001 AND address.city = Paris AND address.latitude = 48.87171000000000020691004465334117412567138671875 AND address.longitude = 2.308288999999999813184103913954459130764007568359375)
E   6. INSERT INTO offerer_address (label, "addressId", "offererId") VALUES (None, 1021, 1484) RETURNING offerer_address.id
E   7. SELECT offerer_address.id AS offerer_address_id, offerer_address.label AS offerer_address_label, offerer_address."addressId" AS "offerer_address_addressId", offerer_address."offererId" AS "offerer_address_offererId", address_1.id AS address_1_id, address_1."banId" AS "address_1_banId", address_1."inseeCode" AS "address_1_inseeCode", address_1.street AS address_1_street, address_1."postalCode" AS "address_1_postalCode", address_1.city AS address_1_city, address_1.latitude AS address_1_latitude, address_1.longitude AS address_1_longitude, address_1."departmentCode" AS "address_1_departmentCode", address_1.timezone AS address_1_timezone, address_1."isManualEdition" AS "address_1_isManualEdition" 
E       FROM offerer_address LEFT OUTER JOIN address AS address_1 ON address_1.id = offerer_address."addressId" 
E       WHERE offerer_address."offererId" = 1484 AND offerer_address.label IS NULL AND offerer_address."addressId" = 1021
E   8. ROLLBACK TO SAVEPOINT sa_savepoint_65
E   9. SELECT address.id AS address_id, address."banId" AS "address_banId", address."inseeCode" AS "address_inseeCode", address.street AS address_street, address."postalCode" AS "address_postalCode", address.city AS address_city, address.latitude AS address_latitude, address.longitude AS address_longitude, address."departmentCode" AS "address_departmentCode", address.timezone AS address_timezone, address."isManualEdition" AS "address_isManualEdition" 
E       FROM address 
E       WHERE address.id = 1021
E   10. SELECT offerer_address.id AS offerer_address_id, offerer_address.label AS offerer_address_label, offerer_address."addressId" AS "offerer_address_addressId", offerer_address."offererId" AS "offerer_address_offererId" 
E       FROM offerer_address 
E       WHERE offerer_address.id = 1319