(PC-32489)[API] feat: change db constraint to allow multiple identica… #14658
+56
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksDPass
force-pushed
the
anougbele-pass/PC-32489-api-modifier-la-contrainte-ix-unique-offerer-address-per-label-even-with-nulls-values
branch
2 times, most recently
from
aaa0943
to
e740971
Compare
xordoquy
reviewed
Oct 21, 2024
| # pre/post deployment: post | ||
| # revision identifiers, used by Alembic. | ||
| revision = "3d909838fadc" | ||
| down_revision = "5adc36a47352" |
There was a problem hiding this comment.
Ce serait plus sécurisant de rajouter d'abord la contrainte et d'enlever l'autre après 🙏
api/src/pcapi/core/offerers/api.py
Outdated
| @@ -2818,7 +2821,7 @@ def get_or_create_offerer_address(offerer_id: int, address_id: int, label: str | | |||
| models.OffererAddress.addressId == address_id, | |||
| ) | |||
| .options(sa_orm.joinedload(models.OffererAddress.address)) | |||
| .one() | |||
| .first() | |||
There was a problem hiding this comment.
Je ne suis pas à l'aise avec cette modification.
Est-ce que l'on ne pourrait pas faire un ticket pour remodifier ça après la PR qui ajoute le create_offerer_address et le passage du script ?
…l offererAddress with label null
AleksDPass
force-pushed
the
anougbele-pass/PC-32489-api-modifier-la-contrainte-ix-unique-offerer-address-per-label-even-with-nulls-values
branch
from
e740971
to
2466987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l offererAddress with label null
But de la pull request
Permettre d'avoir plusieur offererAddress avec les meme adresse et offerer avec un label null
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32489
Vérifications