Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-32281)[PRO] test: migrate e2e desk without factory #14541

Merged
merged 3 commits into from
Oct 21, 2024
Merged

(PC-32281)[PRO] test: migrate e2e desk without factory #14541

merged 3 commits into from
Oct 21, 2024
+242 −6,702

Conversation

scolson-pass
Copy link
Contributor

@scolson-pass scolson-pass commented Oct 9, 2024 •
edited
Loading

But de la pull request

  • Migration de desk sans Cucumber.
  • Nettyage des test e2e (ci, retrait de la sandbox e2e, déplacement des fichiers de tests)

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit deacdc0):

https://pc-pro-testing--pr14541-pc-32281-migrate-e2e-ggu86rue.web.app

(expires Wed, 23 Oct 2024 15:43:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@Aliochka Aliochka marked this pull request as ready for review October 16, 2024 08:42
scolson-pass
scolson-pass commented Oct 17, 2024
View reviewed changes
Copy link
Contributor Author

@scolson-pass scolson-pass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: il manque le cas "Saisie de la contremarque d'une réservation non confirmée".
Saisie de la contremarque d'une réservation non confirmée/validation impossible car moins de 48h après la création de la résa "veuillez attendre jusqu'au xx/xx/xx XXh"

image

@Aliochka Aliochka force-pushed the PC-32281-migrate-e2e-desk branch 2 times, most recently from d1bbda9 to b499654 Compare October 21, 2024 07:59
scolson-pass
scolson-pass commented Oct 21, 2024
View reviewed changes
Copy link
Contributor Author

@scolson-pass scolson-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi, il ne reste plus qu'à squasher

@Aliochka Aliochka force-pushed the PC-32281-migrate-e2e-desk branch 2 times, most recently from df3e7ff to 188fc96 Compare October 21, 2024 09:48
@scolson-pass scolson-pass requested review from a team as code owners October 21, 2024 12:30
@scolson-pass scolson-pass force-pushed the PC-32281-migrate-e2e-desk branch 2 times, most recently from 86c0a62 to d04372c Compare October 21, 2024 14:02
@scolson-pass
(PC-32281)[PRO] test: migrate e2e desk without factory
16ca13e 
stepLogs

(PC-32281)[PRO] test: finish e2e migration desk

(PC-32281)[PRO] test: e2e try to fix flaky financialManagement

(PC-32281)[PRO] test: activate cypress cloud on branch (temp)
@scolson-pass
(PC-32281)[PRO] test: remove useless sandbox e2e
01fc86d 
(PC-32281)[PRO] test: remove useless sandbox e2e

oubli

(PC-32281)[PRO] test: move test

fix
@scolson-pass scolson-pass merged commit 3fd8ca0 into master Oct 21, 2024
28 checks passed
@scolson-pass scolson-pass deleted the PC-32281-migrate-e2e-desk branch October 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aliochka Aliochka Aliochka approved these changes

@mgeoffray-pass mgeoffray-pass mgeoffray-pass approved these changes

@abouabdallaoui-pass abouabdallaoui-pass abouabdallaoui-pass approved these changes

@xdekoninck-pass xdekoninck-pass xdekoninck-pass approved these changes

Assignees

@Aliochka Aliochka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scolson-pass @Aliochka @mgeoffray-pass @abouabdallaoui-pass @xdekoninck-pass