(PC-31894)[API] feat: remove description double writing #14209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeoffray-pass
changed the base branch from
master
to
mageoffray/pc-29599-bis-delete-description
5 tasks
mgeoffray-pass
force-pushed
the
mageoffray/PC-31894-remove-description-double-writing
branch
from
ba7085f
to
174df6a
Compare
damien-ramelet
approved these changes
Sep 18, 2024
prouzet
approved these changes
Sep 18, 2024
| @@ -287,10 +289,15 @@ def test_build_new_offers_from_stock_details(self): | |||
| provider_id=provider.id, | |||
| ) | |||
|
|
|||
| # We need to commit to have the offer description property working | |||
There was a problem hiding this comment.
Question : même pas avec un flush() ?
There was a problem hiding this comment.
Oui, avec un flush j'ai offer.description = None
Base automatically changed from
mageoffray/pc-29599-bis-delete-description
to
master
September 19, 2024 08:38
mgeoffray-pass
force-pushed
the
mageoffray/PC-31894-remove-description-double-writing
branch
2 times, most recently
from
a4615d8
to
34ef587
Compare
mgeoffray-pass
force-pushed
the
mageoffray/PC-31894-remove-description-double-writing
branch
from
34ef587
to
87579b3
Compare
|
Have yourself a merry little break and learn a few facts about the year 449. |
mgeoffray-pass
deleted the
mageoffray/PC-31894-remove-description-double-writing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31894
Do not save description in offer when a product is linked to this offer
Vérifications