(PC-34253)[PRO] test: closed offerer can still list and download book…

…ings
pass-culture · Feb 12, 2025 · 1f15c8d · 1f15c8d
1 parent f7650a3
commit 1f15c8d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/api/tests/routes/pro/get_all_bookings_test.py b/api/tests/routes/pro/get_all_bookings_test.py
@@ -142,8 +142,14 @@ class Returns200Test:
     expected_num_queries += 1  # CTE built over booking, stock and external_booking
     expected_num_queries += 1  # 4.external_booking
 
-    def test_when_user_is_linked_to_a_valid_offerer(self, client: Any):
-        stock = offers_factories.StockFactory(offer__extraData={"ean": "1234567891234"})
+    @pytest.mark.parametrize(
+        "offerer_factory", [offerers_factories.OffererFactory, offerers_factories.ClosedOffererFactory]
+    )
+    def test_when_user_is_linked_to_a_valid_offerer(self, client: Any, offerer_factory):
+        stock = offers_factories.StockFactory(
+            offer__extraData={"ean": "1234567891234"},
+            offer__venue__managingOfferer=offerer_factory(),
+        )
         used_booking = bookings_factories.UsedBookingFactory(
             dateCreated=datetime(2020, 8, 11, 12, 0, 0),
             dateUsed=datetime(2020, 8, 13, 12, 0, 0),

diff --git a/api/tests/routes/pro/get_collective_booking_csv_test.py b/api/tests/routes/pro/get_collective_booking_csv_test.py
@@ -23,8 +23,11 @@ class Returns200Test:
     num_queries += 1  # Fetch the user
     num_queries += 1  # Select collective_booking
 
-    def test_complete_booking_single(self, client):
-        user_offerer = offerers_factories.UserOffererFactory()
+    @pytest.mark.parametrize(
+        "offerer_factory", [offerers_factories.OffererFactory, offerers_factories.ClosedOffererFactory]
+    )
+    def test_complete_booking_single(self, client, offerer_factory):
+        user_offerer = offerers_factories.UserOffererFactory(offerer=offerer_factory())
         booking = educational_factories.CollectiveBookingFactory(
             dateCreated=datetime(2020, 8, 11, 12, 0, 0),
             collectiveStock__startDatetime=datetime(2020, 8, 13, 12, 0, 0),

diff --git a/api/tests/routes/pro/get_collective_booking_excel_test.py b/api/tests/routes/pro/get_collective_booking_excel_test.py
@@ -24,8 +24,11 @@ class Returns200Test:
     num_queries += 1  # Fetch the user
     num_queries += 1  # Fetch the collective_booking
 
-    def test_complete_booking_single(self, client):
-        user_offerer = offerers_factories.UserOffererFactory()
+    @pytest.mark.parametrize(
+        "offerer_factory", [offerers_factories.OffererFactory, offerers_factories.ClosedOffererFactory]
+    )
+    def test_complete_booking_single(self, client, offerer_factory):
+        user_offerer = offerers_factories.UserOffererFactory(offerer=offerer_factory())
         booking = educational_factories.CollectiveBookingFactory(
             dateCreated=datetime(2020, 8, 11, 12, 0, 0),
             collectiveStock__startDatetime=datetime(2020, 8, 13, 12, 0, 0),