Skip to content
1 [on_pull_request] Initiate workflow

(PC-34397)[PRO] feat: use localStorage to never display headline offer banner again once closed #11186

Sign in to view logs

(PC-34397)[PRO] feat: use localStorage to never display headline offer banner again once closed

(PC-34397)[PRO] feat: use localStorage to never display headline offer banner again once closed #11186

Triggered via pull request February 7, 2025 10:01
@asaez-passasaez-pass
synchronize #16209
PC-34397-headline-offer-banner-remember-close
Status Failure
Total duration 11m 45s
Artifacts 2

dev_on_pull_request_workflow.yml

on: pull_request
Init job
41s
Init job
Pro Units Tests  /  Code/Type/Style Quality check
1m 21s
Pro Units Tests / Code/Type/Style Quality check
[pcapi-tests] build docker image.  /  Build Docker image
[pcapi-tests] build docker image. / Build Docker image
[pcapi] build docker image.  /  Build Docker image
[pcapi] build docker image. / Build Docker image
Matrix: Pro Units Tests / Pro Unit tests
MyPy cop  /  MyPy cop test
MyPy cop / MyPy cop test
Tests API documentation  /  Check API documentation can be built
Tests API documentation / Check API documentation can be built
[pcapi-console] build docker image.  /  Build Docker image
[pcapi-console] build docker image. / Build Docker image
Matrix: Tests api / Pytest
Waiting for pending jobs
Tests api  /  Pylint
Tests api / Pylint
Tests api  /  Quality checks
Tests api / Quality checks
Tests api  /  Test database schema
Tests api / Test database schema
Tests pro E2E  /  E2E tests and notifications
10m 46s
Tests pro E2E / E2E tests and notifications
Update api client template  /  Update API Client template
Update api client template / Update API Client template
Pro Units Tests  /  merge-allure-reports
0s
Pro Units Tests / merge-allure-reports
Pro Units Tests  /  merge-reports
38s
Pro Units Tests / merge-reports
Push pcapi docker image to registry  /  Push Docker image
Push pcapi docker image to registry / Push Docker image
Push pcapi-console docker image to registry  /  Push Docker image
Push pcapi-console docker image to registry / Push Docker image
[PRO] Deploy PR version for validation with testing backend  /  deploy_on_firebase
1m 16s
[PRO] Deploy PR version for validation with testing backend / deploy_on_firebase
[PRO] Deploy PR version for validation pr preview backend  /  deploy_on_firebase
[PRO] Deploy PR version for validation pr preview backend / deploy_on_firebase
Dependabot  /  dependabot
Dependabot / dependabot
Fit to window
Zoom out
Zoom in

Annotations

3 errors, 10 warnings, and 1 notice
Pro Units Tests / Pro Unit tests (1, 2)
Process completed with exit code 1.
Pro Units Tests / Pro Unit tests (2, 2)
The job was canceled because "_1_2" failed.
Pro Units Tests / merge-reports
Process completed with exit code 1.
Pro Units Tests / Code/Type/Style Quality check: pro/src/app/App/hook/useLogNavigation.ts#L32
React Hook useEffect has missing dependencies: 'params' and 'previousPage'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/commons/hooks/useRedirectLoggedUser.ts#L50
React Hook useEffect has missing dependencies: 'dispatch', 'navigate', and 'redirectToUrl'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/Address/Address.tsx#L85
React Hook useEffect has missing dependencies: 'addressesMap', 'searchField', and 'setFieldValue'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/Bookings/Bookings.tsx#L203
React Hook useEffect has missing dependencies: 'initialAppliedFilters.bookingBeginningDate', 'initialAppliedFilters.bookingEndingDate', 'initialAppliedFilters.bookingStatusFilter', and 'initialAppliedFilters.offerEventDate'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/Bookings/BookingsRecapTable/BookingsRecapTable.tsx#L81
React Hook useEffect has a missing dependency: 'applyFilters'. Either include it or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/Bookings/PreFilters/PreFilters.tsx#L172
React Hook useCallback has an unnecessary dependency: 'audience'. Either exclude it or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/ImageUploader/components/ButtonImageEdit/ModalImageEdit/ModalImageEdit.tsx#L69
React Hook useEffect has missing dependencies: 'initialImageUrl', 'initialOriginalImageUrl', and 'notification'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/IndividualOffer/StocksThing/StocksThing.tsx#L93
React Hook useEffect has missing dependencies: 'formik', 'offer', and 'useOffererAddressAsDataSourceEnabled'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/IndividualOffer/hooks/useNotifyFormError.ts#L21
React Hook useEffect has missing dependencies: 'errors' and 'notify'. Either include them or remove the dependency array
Pro Units Tests / Code/Type/Style Quality check: pro/src/components/IndividualOffer/hooks/useNotifyFormError.ts#L21
React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
Tests pro E2E / E2E tests and notifications
Running e2e-tests with europe-west1-docker.pkg.dev/passculture-infra-prod/pass-culture-artifact-registry/pcapi:latest

Artifacts

Produced during runtime
Name Size
blob-report-1 Expired
768 KB
blob-report-2 Expired
763 KB