-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leakage #720
Add leakage #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the recent changes in the Hamiltonian
because the set_config()
exists and thus the dimensions might change if leakage is added?
Yes indeed :) I think I have covered everything on this side. However, if you feel it's too much trouble for a feature that is not too much used, another option could be to just raise an error when the user do set_config, with a Config having a different leakage than the previous config... |
It's just that I think we'll want to deprecate |
Okay I think I am good :) |
The execution is now consistent:
|
tests/test_simulation.py
Outdated
assert sim._initial_state == qutip.tensor( | ||
[qutip.basis(2, 1) for _ in range(2)] | ||
) | ||
print("Final test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot this
**Main changes:** - Reworking the NoiseModel interface (#710) - Allow modification of the EOM setpoint without disabling EOM mode (#708) - Enable definition of effective noise operators in all basis (#716) - Add leakage (#720) - Support differentiability through Torch tensors (#703) - Add from_abstract_repr to Device and VirtualDevice (#727) - [FEAT] Handle batches with partial results (#707) - Add open batches to pulser-pasqal (#701)
Implements the "leakage" noise. When "leakage" is provided as a
noise
in theSimConfig
:operators
in Hamiltonian (seeconstruct_hamiltonian
) since they changed size