Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing pipeline for test of relaxation noise in qutrit state #719

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Aug 7, 2024

Fixes merge of #716

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@a-corni a-corni requested a review from HGSilveri August 7, 2024 09:09
@HGSilveri
Copy link
Collaborator

HGSilveri commented Aug 7, 2024

You should rebase on develop to include just the last commit (if that doesn't work, you might have to make a new branch and force push it). Also, let's temporarily enable the CI tests on mac-os to make sure it is indeed fixed

tests/test_simulation.py Outdated Show resolved Hide resolved
@a-corni
Copy link
Collaborator Author

a-corni commented Aug 7, 2024

@HGSilveri I am done with the tests, you can see that the pipeline now works with macos

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-corni a-corni merged commit c9f7957 into develop Aug 7, 2024
7 checks passed
@a-corni a-corni deleted the noise_all branch August 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants