Add support for pulser-diff backend #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGSilveri
reviewed
May 21, 2024
…coordinates are differentiable with pulser-diff
HGSilveri
reviewed
May 28, 2024
HGSilveri
reviewed
May 29, 2024
HGSilveri
reviewed
May 29, 2024
HGSilveri
reviewed
May 29, 2024
HGSilveri
approved these changes
May 29, 2024
HGSilveri
pushed a commit
that referenced
this pull request
May 30, 2024
* works with basic features of pulser-diff * Fixed phase attribute setting; removed debugging code; reverted unnecessary changes * Modified register creation code to work with AbstractArray; register coordinates are differentiable with pulser-diff * Fixed type hints * Minor fixes and refactoring * Modified ParamObj code to work with quantum model training in pulser-diff * Minor refactoring; add possibility to ensure 0D AbstractArray is reshaped into 1D * Force array only for scalars
HGSilveri
pushed a commit
that referenced
this pull request
Jun 13, 2024
* works with basic features of pulser-diff * Fixed phase attribute setting; removed debugging code; reverted unnecessary changes * Modified register creation code to work with AbstractArray; register coordinates are differentiable with pulser-diff * Fixed type hints * Minor fixes and refactoring * Modified ParamObj code to work with quantum model training in pulser-diff * Minor refactoring; add possibility to ensure 0D AbstractArray is reshaped into 1D * Force array only for scalars
HGSilveri
pushed a commit
that referenced
this pull request
Jun 13, 2024
* works with basic features of pulser-diff * Fixed phase attribute setting; removed debugging code; reverted unnecessary changes * Modified register creation code to work with AbstractArray; register coordinates are differentiable with pulser-diff * Fixed type hints * Minor fixes and refactoring * Modified ParamObj code to work with quantum model training in pulser-diff * Minor refactoring; add possibility to ensure 0D AbstractArray is reshaped into 1D * Force array only for scalars
HGSilveri
pushed a commit
that referenced
this pull request
Jun 26, 2024
* works with basic features of pulser-diff * Fixed phase attribute setting; removed debugging code; reverted unnecessary changes * Modified register creation code to work with AbstractArray; register coordinates are differentiable with pulser-diff * Fixed type hints * Minor fixes and refactoring * Modified ParamObj code to work with quantum model training in pulser-diff * Minor refactoring; add possibility to ensure 0D AbstractArray is reshaped into 1D * Force array only for scalars
HGSilveri
added a commit
that referenced
this pull request
Sep 17, 2024
* Defining pulser.math and AbstractArray * POC: Differentiable constant pulse amp Typing is still failing * Fix typing in waveforms * Fix all typing errors in POC * Pass all existing UTs * Pass all UTs without array support * Fix typing * All tests pass with torch installed * Add support for pulser-diff backend (#686) * works with basic features of pulser-diff * Fixed phase attribute setting; removed debugging code; reverted unnecessary changes * Modified register creation code to work with AbstractArray; register coordinates are differentiable with pulser-diff * Fixed type hints * Minor fixes and refactoring * Modified ParamObj code to work with quantum model training in pulser-diff * Minor refactoring; add possibility to ensure 0D AbstractArray is reshaped into 1D * Force array only for scalars * Fix UTs after pulser-diff changes * Avoid using AbstractArrayLike outside of pulser.math * Preserve gradient in EOM mode * Add torch as an optional requirement * Support waveform multiplication with abstract array * Explicitly marking the differentiable parameters * Remove __array_wrap__ * Pass relevant UTs without array support * Support new features * Using pm.Differentiable whenever possible * Simplifying Waveform.__getitem__() type hint * UTs for new features outside of pulser.math * Write torch UTs for registers * Write UTs for waveforms * UTs for pulse * UTs for EOM * UTs on internal functionality * UTs for Sequence with autograd * Implicitly cover math functions * Removing AbstractArray.__hash__() and differentiable phase shifts * Finish unit tests * Update CI to run tests with and without torch * Fix CI errors * Fix failing no-torch UT * Minor corrections * Include pulser[torch] installation in the README * Fix warning in UT after merge * Incorporating the latest changes * Fix typing * Addressing review comments * Including `detach()` in Differentiable protocol * Differentiable -> TensorLike * Tentatively allow waveform division by array * Full coverage --------- Co-authored-by: Vytautas Abramavicius <145791635+vytautas-a@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
pulser-coreto support all current features of differentiabletorchbackend.