Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable case value-keyword-case for composes #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pascalduez
Copy link
Owner

@pascalduez pascalduez commented Feb 8, 2024

See #7, #13

Just checking what it takes, whether it make sense or not.

While this "solves" the issue with classes used with composes. This does not solve the one with @value.

@value camelCase: green;
a { color: camelCase } /* error */

Since @value can be used in a wide range of properties, we don't have much solutions here.

Also we can see that disabling selector-class-pattern was necessary locally.
The CSS modules spec don't enforce a particular case, so this config won't disable selector-class-pattern. It's out of scope.

The whole benefit of this change is quite debatable, some per projects overrides will always be needed.
One would still need to:

  • disable selector-class-pattern locally
  • change case for @value or build a unmaintainable list of ignored properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant