-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meshblock Cost Function and Diagnostics #892
Conversation
Resolves #576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Athenapk folks: @pgrete @forrestglines do you want to take a look or should I just pull the trigger? I think the impact on athenapk is minimal. |
If I don't hear from AthenaPK folks by the end of tomorrow (Tuesday), I'll just pull the trigger. I don't think there's anything in here that should impact you. |
PR Summary
Again part of the effort to get riot onto parthenon develop. Here I pull several features in from riot:
Memory Diagnostics Per Meshblock
Whenever variables or swarms are allocated or deallocated, memory used on a given meshblock is updated in a running total. Note this is only "interior" data. I also add the ability to look at the comm buffer pool, but this is a per-mesh quantity since the pool is shared. Not per block. I also didn't add the equivalent logic for boundary swarms, as I didn't fully understand the swarm machinery, and it's probably a negligible contribution. @brryan should probably take a look at the memory diagnostic logic for swarms in case I missed something.
I showcase this capability by modifying the sparse example to show memory footprint in bytes per cycle.
Manual load balancing
parthenon/loadbalancing/balancer=manual
.I also document both of the above new features.
PR Checklist