fix movie2d. Resolves #832. #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brryan
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Thanks for fixing this @Yurlungur, sorry I didn't notice this. A few small comments if you agree with them and want to make those changes, but I'll go ahead and approve now.
scripts/python/packages/parthenon_tools/parthenon_tools/movie2d.py
Outdated
Show resolved
Hide resolved
scripts/python/packages/parthenon_tools/parthenon_tools/movie2d.py
Outdated
Show resolved
Hide resolved
scripts/python/packages/parthenon_tools/parthenon_tools/movie2d.py
Outdated
Show resolved
Hide resolved
pgrete
approved these changes
Feb 14, 2023
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As @pgrete noted in #832 , the movie script is currently broken. This was due to the change to outputting more than just vector- or scalar-valued variables. Here I fix this by allowing the user to optionally pass in tensor components, which default to 0 for a scalar.
I wanted to also add a test to make sure the movie script was working. And there's a way to do this---we can generate a png file as a gold file and compare to that---but I wasn't sure if we wanted to pull in the additional dependency of Pillow. See here. If people are ok with including Pillow as an additional python dependency, then we can add that test later. I don't have the time to do so right now.
PR Checklist