Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOKKOS_DISABLE_WARNINGS #791

Merged
merged 3 commits into from
Nov 30, 2022
Merged

KOKKOS_DISABLE_WARNINGS #791

merged 3 commits into from
Nov 30, 2022

Conversation

tagardiner
Copy link
Collaborator

@tagardiner tagardiner commented Nov 21, 2022 •
edited
Loading

Kokkos@3.7.0 requires either (true, false) (1, 0) or (yes, no) for booleans.

This fixes the env. var. KOKKOS_DISABLE_WARNINGS=TRUE

  • Code passes cpplint
  • New features are documented. (N/A)
  • Adds a test for any bugs fixed. Adds tests for new features. (N/A)
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • (@lanl.gov employees) Update copyright on changed files

@tagardiner tagardiner mentioned this pull request Nov 21, 2022
Closed
@tagardiner tagardiner enabled auto-merge November 21, 2022 17:11
@pgrete pgrete linked an issue Nov 23, 2022 that may be closed by this pull request
KOKKOS_DISABLE_WARNINGS=ON #790
Closed
bprather
bprather approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@bprather bprather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Going to have to comb my run scripts for this now...

@pgrete pgrete disabled auto-merge November 30, 2022 19:10
@pgrete pgrete enabled auto-merge (squash) November 30, 2022 19:10
@pgrete
Copy link
Collaborator

pgrete commented Nov 30, 2022

Had to reenable auto-merge after the latest merge from develop in order to trigger the extended CI again.

@pgrete pgrete merged commit e0fa8e4 into develop Nov 30, 2022
@tagardiner tagardiner mentioned this pull request Nov 30, 2022
Merged
7 tasks
@Yurlungur Yurlungur deleted the tagardiner/kokkos-disable-warnings branch December 3, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@bprather bprather bprather approved these changes

@pgrete pgrete pgrete approved these changes

@jonahm-LANL jonahm-LANL Awaiting requested review from jonahm-LANL

@jdolence jdolence Awaiting requested review from jdolence

@lroberts36 lroberts36 Awaiting requested review from lroberts36

@forrestglines forrestglines Awaiting requested review from forrestglines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KOKKOS_DISABLE_WARNINGS=ON
5 participants
@tagardiner @pgrete @Yurlungur @bprather @tagardi