[small] fix type mismatch #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolence
approved these changes
Aug 19, 2022
pgrete
pushed a commit
that referenced
this pull request
Aug 29, 2022
* fix type mismatch * changelog and copyright * oops wrong copyright Co-authored-by: Jonah Maxwell Miller <jonahm@lanl.gov>
pgrete
added a commit
that referenced
this pull request
Aug 30, 2022
* Add message to static_assert (no message is C++17) * Remove unused return type from IOWrapper::Open * Remove pre-C++17 compiler warnings * Write XDMF for restarts, too * Remove data transpose from hdf5 output * Introduce backwards compatiblity * Use const var to write output version * Protect format * Fix typo * Add Changelog * Apply suggestions from code review Co-authored-by: Luke Roberts <lfroberts@lanl.gov> * [small] fix type mismatch (#719) * fix type mismatch * changelog and copyright * oops wrong copyright Co-authored-by: Jonah Maxwell Miller <jonahm@lanl.gov> * Add deprecation todo for python output reader * Remove outdated performance regression test Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com> Co-authored-by: Luke Roberts <lfroberts@lanl.gov> Co-authored-by: Jonah Maxwell Miller <jonahm@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The swarm boundaries assume
ParArray1Dis always the correct type for boundary buffers. However, when host pinned memory is enabled, this type is identical, asBufArray1Dhas a different memory space. This tiny PR fixes this bug so that the code compiles when you set-DPARTHENON_ENABLE_HOST_COMM_BUFFERS=ON. (This is a useful thing for us to continue to support, as it allows us to run on systems without cuda-aware MPI and helps with debugging.)PR Checklist