Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Kokkos release #536

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Update to latest Kokkos release #536

merged 2 commits into from
Jun 3, 2021

Conversation

jdolence
Copy link
Collaborator

@jdolence jdolence commented Jun 2, 2021

PR Summary

Updating to Kokkos v3.4.1

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But we should make sure the full test suite passes before merging

Copy link
Collaborator

@jlippuner jlippuner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @Yurlungur that we need to ensure all tests pass before merging

@Yurlungur
Copy link
Collaborator

Triggered the full test suite and it all passes. I think this is ready. Pinging @pgrete @forrestglines to see if they have any objections.

@jdolence
Copy link
Collaborator Author

jdolence commented Jun 2, 2021

Everything appears to pass so this should be ready to go in. I'll give @pgrete and @forrestglines a chance to object, but will merge this in tomorrow if I don't hear anything.

Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very welcome change (AthenaPK already uses a more recent Kokkos version)

@pgrete pgrete merged commit 0c9c14d into develop Jun 3, 2021
@pgrete pgrete deleted the jdolence/update_kokkos branch June 3, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants