Update apply-formatting.yml

[JoshuaSBrown]

PR Summary

Adding formatting capability to python source files. Parthenon now makes use of several python scripts. It makes sense to expand automatic formatting to the python files. This is achieved in this pr by editing the formatting files that @AndrewGaspar implemented.

Now the ci will both look at python files and cpp files and run a pass or fail check. The par-hermes trigger can also be called as before. Which will auto format the python files in the repository.

PR Checklist

• Code passes cpplint
• New features are documented.
• Adds a test for any bugs fixed. Adds tests for new features.
• Code is formatted
• Changes are summarized in CHANGELOG.md
• CI has been triggered on Darwin for performance regression tests.
• (@lanl.gov employees) Update copyright on changed files

[JoshuaSBrown]

@par-hermes format

[JoshuaSBrown]

@par-hermes format

[JoshuaSBrown]

@par-hermes format

[JoshuaSBrown]

@par-hermes format

[JoshuaSBrown]

I don't think the Check C++ Formatting action is going to run for this pr because I have changed it.

[Yurlungur]

Nice! What about a command for local formatting? I.e., can we run make format to format the python scripts?

[JoshuaSBrown]

Nice! What about a command for local formatting? I.e., can we run make format to format the python scripts?

Ya, I got lazy. Lol.

[Yurlungur]

Nice! What about a command for local formatting? I.e., can we run make format to format the python scripts?

Ya, I got lazy. Lol.

I vastly prefer doing local formatting over calling par-hermes, because I'm old-school and I like CLI's I guess. :P

[JoshuaSBrown]

Nice! What about a command for local formatting? I.e., can we run make format to format the python scripts?

Ya, I got lazy. Lol.

I vastly prefer doing local formatting over calling par-hermes, because I'm old-school and I like CLI's I guess. :P

Making me earn my pay. :)

[jlippuner]

This is a great addition and I agree that we need automated formatting for Python code. I do agree that it would be nice to have local formatting of the Python code (like make format), although I don't consider it absolutely necessary. After all, we mostly work on the C++ code and the Python code doesn't change that often (and there isn't that much to begin with). So if it turns out be a huge pain to implement local Python formatting, I'd be ok to forgo it, provided that par-hermes works.

One more thing, this PR changes a lot of .py files, but it looks like just formatting. Did you make any code changes to any .py files? If so, I think we should have separate PRs for code and infrastructure changes and then all the formatting changes in another PR. But if all the changes to the Python files in this PR are purely formatting, then I think it's ok to have them in this PR.

[JoshuaSBrown]

This is a great addition and I agree that we need automated formatting for Python code. I do agree that it would be nice to have local formatting of the Python code (like make format), although I don't consider it absolutely necessary. After all, we mostly work on the C++ code and the Python code doesn't change that often (and there isn't that much to begin with). So if it turns out be a huge pain to implement local Python formatting, I'd be ok to forgo it, provided that par-hermes works.

One more thing, this PR changes a lot of .py files, but it looks like just formatting. Did you make any code changes to any .py files? If so, I think we should have separate PRs for code and infrastructure changes and then all the formatting changes in another PR. But if all the changes to the Python files in this PR are purely formatting, then I think it's ok to have them in this PR.

No I did not change any py files, changes made are only to build configuration and ci.

[JoshuaSBrown]

Nice! What about a command for local formatting? I.e., can we run make format to format the python scripts?

Ya, I got lazy. Lol.

I vastly prefer doing local formatting over calling par-hermes, because I'm old-school and I like CLI's I guess. :P

You should be happy now.

[pgrete]

Looks great. I also confirmed that make format locally works as expected!
Pending my minor comments I'm happy to see this going in.
Also, as next step, we could also consider adding a flake8 step.

[JoshuaSBrown]

Thanks everyone for the input.

[Yurlungur]

Awesome. Thanks, @JoshuaSBrown !