-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use subviews of a single view for fluxes #502
Conversation
… meshblock pointer isn't available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that this PR is half a mixture of the original coarse buffer plus fluxes with coarse buffers being pulled out again (but not all names and comments updated yet?
Co-authored-by: Philipp Grete <gretephi@msu.edu>
Thanks for the catch, @pgrete fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to disregard the nitpicking/style comments. Only the allocation itself should likely be done within the Metadata conditional.
Co-authored-by: Philipp Grete <gretephi@msu.edu>
Co-authored-by: Philipp Grete <gretephi@msu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any problems with this pr. Thanks @Yurlungur.
Thanks for your comments, @pgrete. I believe all issues should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Same as PR #494
PR Summary
PR Checklist