Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subviews of a single view for fluxes #502

Merged
merged 19 commits into from
May 19, 2021
Merged

Use subviews of a single view for fluxes #502

merged 19 commits into from
May 19, 2021

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Apr 27, 2021

Same as PR #494

PR Summary

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur requested review from JoshuaSBrown and pgrete May 13, 2021 18:09
Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that this PR is half a mixture of the original coarse buffer plus fluxes with coarse buffers being pulled out again (but not all names and comments updated yet?

src/bvals/bvals_interfaces.hpp Outdated Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator Author

Thanks for the catch, @pgrete fixed.

@pgrete pgrete changed the title Jmm/one buffer Use subviews of a single view for fluxes May 14, 2021
Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to disregard the nitpicking/style comments. Only the allocation itself should likely be done within the Metadata conditional.

CHANGELOG.md Outdated Show resolved Hide resolved
src/interface/variable.hpp Outdated Show resolved Hide resolved
src/interface/variable.cpp Show resolved Hide resolved
src/interface/variable.cpp Outdated Show resolved Hide resolved
src/interface/variable.cpp Outdated Show resolved Hide resolved
src/interface/variable.cpp Outdated Show resolved Hide resolved
src/interface/variable.cpp Outdated Show resolved Hide resolved
Yurlungur and others added 2 commits May 14, 2021 09:47
Co-authored-by: Philipp Grete <gretephi@msu.edu>
Co-authored-by: Philipp Grete <gretephi@msu.edu>
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems with this pr. Thanks @Yurlungur.

@Yurlungur
Copy link
Collaborator Author

Thanks for your comments, @pgrete. I believe all issues should be resolved now.

Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@pgrete pgrete merged commit 9acff25 into develop May 19, 2021
@Yurlungur Yurlungur deleted the jmm/one-buffer branch May 19, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants