Update docker file (for latest nsys) #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrete
force-pushed
the
pgrete/update-ci-cuda113
branch
from
ee4b12a to
785a575
Compare
|
I now also updated the thresholds for the Overlapping SpaceInstances so that they are less restrictive (but still check the SpaceInstances themselves work), see also #489 |
Yurlungur
approved these changes
Apr 26, 2021
|
Just for reference: I manually triggered the full test suite and it passed. |
jlippuner
approved these changes
Apr 27, 2021
| @@ -622,8 +622,9 @@ struct SmallNLongTBufferPack { | |||
| template <typename TimeType> | |||
| static void test_time(const TimeType time_default, const TimeType time_spaces, | |||
| const int nspaces) { | |||
There was a problem hiding this comment.
So we don't need nspaces anymore? In that case we should do:
Suggested change
| const int nspaces) { | |
| const int /*nspaces*/) { |
There was a problem hiding this comment.
Will handle that in a separate PR not not trigger CI again.
There was a problem hiding this comment.
Curious, is this because of -Wunused-parameter ? Why not remove the const int too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The updated cuda version on the host seems to have resulted in the docker
nsysstalling (with tests timing out after three hours of "finalizing").This updates also the docker image to use Cuda 11.3 with the latest version of
nsys.For reference: We use
nsys profileto ensure there are not unintended host to device or vice versa copies during execution.PR Checklist