Add default tiling matching index range to MDRange loop pattern. #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Addresses performance issue observed by @jdolence when using
par_reduce
.The latter uses an
MDRangePolicy
, which, by default, does not come with tiling information.That results in poor performance on devices as observed before, see, e.g., https://gitlab.com/pgrete/kathena/-/merge_requests/58
The current default may not be perfect for all situations and
MeshBlock
sizes but it's for sure a much better default choice than "no tiling".Partially addresses #466
PR Checklist