Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default tiling matching index range to MDRange loop pattern. #487

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Apr 13, 2021

PR Summary

Addresses performance issue observed by @jdolence when using par_reduce.
The latter uses an MDRangePolicy, which, by default, does not come with tiling information.
That results in poor performance on devices as observed before, see, e.g., https://gitlab.com/pgrete/kathena/-/merge_requests/58
The current default may not be perfect for all situations and MeshBlock sizes but it's for sure a much better default choice than "no tiling".
Partially addresses #466

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • (@lanl.gov employees) Update copyright on changed files

@pgrete
Copy link
Collaborator Author

pgrete commented Apr 13, 2021

@par-hermes format

@pgrete pgrete enabled auto-merge April 14, 2021 20:04
@pgrete pgrete merged commit 2617728 into develop Apr 14, 2021
@pgrete pgrete deleted the pgrete/mdrange-tiling branch April 15, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants