Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #473

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Update CONTRIBUTING.md #473

merged 4 commits into from
Mar 30, 2021

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Mar 16, 2021 •
edited
Loading

PR Summary

Simple documentation pr, explains that forked branches will not automatically trigger the CI. I also added some internal
file links to ease navigation of the Contributing.md file.

PR Checklist

  • Changes are summarized in CHANGELOG.md

pgrete
pgrete approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly extended the description with an example. Otherwise, looks good to go. Thanks!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Yurlungur
Yurlungur approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve with @pgrete 's modifications. Thanks for doing this!

@pgrete
Apply suggestions from code review
61c0b7a 
Co-authored-by: Philipp Grete <gretephi@msu.edu>
@JoshuaSBrown
Copy link
Collaborator Author

@jlippuner ping

@pgrete pgrete enabled auto-merge March 30, 2021 20:04
@pgrete pgrete merged commit b17b99f into develop Mar 30, 2021
@pgrete pgrete deleted the JoshuaSBrown/Documentation-merging-from-fork branch March 31, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@pgrete pgrete pgrete approved these changes

@jlippuner jlippuner Awaiting requested review from jlippuner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaSBrown @Yurlungur @pgrete