Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmm/remove implicit logic #424

Closed
wants to merge 5 commits into from
Closed

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Jan 20, 2021

PR Summary

Resolves the bug found by @clellsolomon and reported in #423. In short, the issue is that a package can have a different label in StateDescriptor than key in Packages_t, however they were assumed to be identical in the code I wrote in MR #386. This MR undoes that assumption by explicitly using keys instead of package labels. I will submit an MR in the future that resolves the ambiguity where each package has two "names."

PR Checklist

  • Code passes cpplint
  • New features are documented. (None)
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md

@Yurlungur Yurlungur added the bug Something isn't working label Jan 20, 2021
@Yurlungur Yurlungur self-assigned this Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #424 (6fee1ad) into develop (4c48a10) will increase coverage by 0.05%.
The diff coverage is 77.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #424      +/-   ##
===========================================
+ Coverage    56.52%   56.58%   +0.05%     
===========================================
  Files          108      108              
  Lines        11055    11078      +23     
===========================================
+ Hits          6249     6268      +19     
- Misses        4806     4810       +4     
Impacted Files Coverage Δ
src/driver/multistage.hpp 100.00% <ø> (ø)
src/interface/meshblock_data.hpp 60.00% <ø> (ø)
src/interface/swarm_container.cpp 0.00% <0.00%> (ø)
src/interface/swarm_container.hpp 18.18% <ø> (ø)
src/interface/variable.hpp 48.38% <0.00%> (ø)
src/mesh/mesh.hpp 44.68% <ø> (ø)
src/outputs/restart.hpp 86.84% <ø> (ø)
src/parameter_input.hpp 100.00% <ø> (ø)
src/mesh/mesh.cpp 52.05% <50.00%> (-0.04%) ⬇️
src/outputs/outputs.hpp 50.00% <66.66%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6595b58...47a8443. Read the comment docs.

@Yurlungur Yurlungur mentioned this pull request Jan 21, 2021
5 tasks
@Yurlungur
Copy link
Collaborator Author

On @AndrewGaspar 's suggestion, I will close this and simply merge in #425 as appropriate.

@Yurlungur Yurlungur closed this Jan 21, 2021
@Yurlungur Yurlungur deleted the jmm/remove-implicit-logic branch April 21, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants