Joshua s brown/codacy cleanup2 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaSBrown
changed the title
JoshuaSBrown
changed the title
JoshuaSBrown
requested review from
jdolence,
AndrewGaspar and
pgrete
and removed request for
jdolence and
AndrewGaspar
JoshuaSBrown
changed the title
JoshuaSBrown
changed the title
|
@pgrete, @AndrewGaspar can I get some feedback on this I would like to get it merged? |
Yurlungur
approved these changes
Jan 26, 2021
AndrewGaspar
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
More cleanup. Const reference issues, reducing variable scope. Deleting unneeded bash build scripts.
PR Checklist