Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing parameter_input #353

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Fixing parameter_input #353

merged 3 commits into from
Nov 5, 2020

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Nov 4, 2020 •
edited
Loading

PR Summary

Fixes a small issue with logic in the parameter_input file, the default bool was always set to false.

PR Checklist

  • Code passes cpplint
  • New features are documented. NA
  • Adds a test for any bugs fixed. Adds tests for new features. NA
  • Code is formatted
  • Changes are summarized in CHANGELOG.md

@JoshuaSBrown JoshuaSBrown linked an issue Nov 4, 2020 that may be closed by this pull request
Always false logic. #344
Closed
@JoshuaSBrown JoshuaSBrown added Error Documenting Errors, may or may not be a bug, could be user setttings, env settings etc. bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Nov 4, 2020
@JoshuaSBrown JoshuaSBrown self-assigned this Nov 4, 2020
@JoshuaSBrown JoshuaSBrown requested a review from jdolence November 4, 2020 17:44
@jdolence
Copy link
Collaborator

jdolence commented Nov 5, 2020

this one is small and simple, so I'm pulling the trigger.

@jdolence jdolence merged commit 5498acf into develop Nov 5, 2020
@jdolence jdolence deleted the JoshuaSBrown/fix-parameter-input branch November 5, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGaspar AndrewGaspar AndrewGaspar approved these changes

@jdolence jdolence jdolence approved these changes

@pgrete pgrete Awaiting requested review from pgrete

Assignees

@JoshuaSBrown JoshuaSBrown

Labels
Error Documenting Errors, may or may not be a bug, could be user setttings, env settings etc. invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always false logic.
3 participants
@JoshuaSBrown @jdolence @AndrewGaspar