Enable openmp in kokkos if openmp is found #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaSBrown
changed the title
AndrewGaspar
suggested changes
Aug 17, 2020
Yurlungur
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
No objections from me. I defer to you and @AndrewGaspar as far as the cmake fu.
added 2 commits
August 20, 2020 12:31
JoshuaSBrown
requested review from
AndrewGaspar,
forrestglines,
jmstone and
pgrete
AndrewGaspar
approved these changes
Aug 20, 2020
pgrete
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It does not make sense that parthenon has openmp enabled by default but that it is not used by Kokkos unless Kokkos_ENABLE_OPENMP is enabled, this is redundant, this pull request attempts to address this by using parthenon's defaults.
PR Checklist