Adjusting gitlab yml for internal trigger of ci #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
June 18, 2020 10:20
|
@JoshuaSBrown you should probably remove the |
added 20 commits
October 28, 2020 13:05
JoshuaSBrown
changed the title
|
Now that the regression tests are passing this is good to go. @pgrete When this is merged the commits should definitely be squashed. |
5 tasks
pgrete
approved these changes
Nov 3, 2020
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Added (new features/APIs/variables/...) | |||
| - [[PR 335]](https://github.com/lanl/parthenon/pull/335) Support for project-relative `MACHINE_CFG` with `@PAR_ROOT@` | |||
| - [[PR 200]](https://github.com/lanl/parthenon/pull/200) Adds support for running ci on power9 nodes. | |||
There was a problem hiding this comment.
This should probably be moved to the new Infrastructure heading.
.gitlab-ci-darwin.yml
Outdated
| MODULE_MPI: "openmpi/p9/4.0.2-gcc_7.4.0" | ||
| NUM_GPU_DEVICES_PER_NODE: 2 | ||
| NUM_MPI_PROC_TESTING: 2 | ||
| OMP_NUM_THREADS: 40 |
There was a problem hiding this comment.
Suggested change
| OMP_NUM_THREADS: 40 | |
| OMP_NUM_THREADS: 1 |
As long as we don't have proper threading support I strongly suggest to set num threads to 1. On the machine I using using more threads significantly slows down the code (in addition to technically not being properly supported).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently, testing triggering of internal ci for use on darwin. Preliminary testing is complete. Ci makes use of build scripts that are located in /scripts/darwin. The reason for using scripts was to help isolate the gitlab ci instance from the user environment.
PR Checklist