Leapfrog fix #1206
Merged
Leapfrog fix #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
approved these changes
Nov 7, 2024
|
OK there's an additional issue which is that our |
This should be fixed with Kokkos 4.4 which has support for sorting on hip (though the interface would need to be updated). |
12 tasks
alexrlongne
reviewed
Nov 7, 2024
alexrlongne
reviewed
Nov 7, 2024
Yes agreed, I can make a separate WIP PR to switch to |
pdmullen
approved these changes
Nov 8, 2024
acreyes
pushed a commit
to acreyes/parthenon
that referenced
this pull request
Nov 14, 2024
* Missing send size init * cleanup, CHANGELOG * verbose CI * further CI debugging * This should be working... * This should be fixed... but I get a segfault on GPU * Is it my AMD GPU thats wrong? * Missing a return statement * retest * Oops missing statement * Revert test * revert workflow
pgrete
added a commit
that referenced
this pull request
Feb 10, 2025
* meshdata version of refinement tagging * got initialization and vector indices working * fix tensor indices * added CheckRefinementMesh to fine-advection example * cleaning up var names * cleanup * adding scatter view utilities * scatterview version of refinement * burgers-benchmark uses Tag<MeshData> * add hierarchial par * cleanup includes * missed one * Update CHANGELOG.md * remove default level tag * default CheckRefineMesh to true * respect amr_criteria max_level * renaming delta_levels->amr_tags, mc->md * fix refinement/bc order * docs for CheckRefinementMesh * move amr_tags array to mesh * adding comments for ScatterMax view * it compiles at least * add easy machinery to register reflecting BCs * changelog * swarm bcs differetn from mesh bcs * use new input block * typo * add error checking for swarm/mesh BC consistency * typo * phdf diff * Register reflecting BCs for advection examples * typo * silly backwards compatibility thing to make it so you don't have to specify swarm BCs if you're not using swarms * working * changelog * Make everything work * format * maybe fix doc issue? * Address CUDA MPI/ICP issue with Kokkos <=4.4.1 (#1189) * Jonah's fix for this CI issue * CHANGELOG * Remove else from if constexpr when there are returns * Consolidate buffer packing functions with less atomics (#1199) * Consolidate buffer packing functions with less atomics + Fold in buffer sizing to the load buffer function + Use a sort and a discontinuity check instead of an atomic_fetch_add inside of LoadBuffer_ to get particle index into buffer + Reduce transcendental functions call in particle sourcing in particle example * Address PR comments + Call the member variable in SwarmKey the sort_key + Remove CountParticlesInBuffer function + Add buffer_start and buffer_sorted as swarm member variables * Update example/particles/particles.cpp Co-authored-by: Ben Ryan <bryan10@illinois.edu> * Update src/interface/swarm_comms.cpp Co-authored-by: Ben Ryan <bryan10@illinois.edu> --------- Co-authored-by: Ben Ryan <bryan10@illinois.edu> Co-authored-by: Ben Ryan <brryan@lanl.gov> * [Trivial] Fix type used for array init (#1170) * Fix type used for array init * init array with constexpr expression * CC --------- Co-authored-by: Jonah Miller <jonahm@lanl.gov> * Leapfrog fix (#1206) * Missing send size init * cleanup, CHANGELOG * verbose CI * further CI debugging * This should be working... * This should be fixed... but I get a segfault on GPU * Is it my AMD GPU thats wrong? * Missing a return statement * retest * Oops missing statement * Revert test * revert workflow * removing meshblock amr_criteria * use pack.UpperBound(b) to check allocation * remove meshblock first/second derivative from cpp * linting --------- Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com> Co-authored-by: Jonah Miller <jonahm@lanl.gov> Co-authored-by: Luke Roberts <lfroberts@lanl.gov> Co-authored-by: Philipp Grete <pgrete@hs.uni-hamburg.de> Co-authored-by: Ben Ryan <brryan@lanl.gov> Co-authored-by: Adam Dempsey <adempsey@lanl.gov> Co-authored-by: Alex Long <along@lanl.gov> Co-authored-by: Ben Ryan <bryan10@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
particle_leapfrog_outflowtest is currently breaking CI intermittently.I think the issue is that, for zero particles on a rank, we don't initialize all
send_sizes to0so sometimes they're full of garbage. This PR seems to cycle correctly.PR Checklist