-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Linear Solver Updates #1174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This seems to be a pretty significantly cleanup along with the new features and better performance.
Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this as-is in KHARMA for ages now, it works for me. The code looks great, I like the simpler interface.
PR Summary
This PR adds a number of solver related things:
poisson_gmg
example.poisson_gmg
example.To facilitate these changes to the solvers and examples, two small changes are made to the rest of the infrastructure:
SparsePack
s to work with multigrid neighbors and include physical boundary information as well. This is a breaking change, since now physical boundaries are denoted with a large, negative level in the array containing neighbor information inSparsePack
Indexer
.PR Checklist