Skip to content

Add conditional compilation for CORS config #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2023
Merged

Add conditional compilation for CORS config #542

merged 4 commits into from
Oct 26, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 26, 2023

Description

  • Remove pyroscope from debug feature
  • Use debug feature for permissive CORS config

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit e7b15c1 into parseablehq:main Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@trueleo trueleo deleted the cargo-feature branch October 31, 2023 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueleo @nitisht