Skip to content

Check memtable against current minute when loading #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

Check memtable against current minute when loading #468

merged 1 commit into from
Aug 7, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 7, 2023

Description

Load mem-table into query conditionally.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht self-requested a review August 7, 2023 09:22
@nitisht nitisht merged commit cdeb9e8 into parseablehq:main Aug 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
@trueleo trueleo deleted the fix_mem branch August 7, 2023 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueleo @nitisht