Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention config shouldn't need logstream to be initialized #398

Merged
merged 1 commit into from
May 7, 2023

Conversation

nitisht
Copy link
Member

@nitisht nitisht commented May 7, 2023

Description

It is common for users to create stream and set the retention (and be done with initial config) before sending logs to the log stream.

Accordingly we're going to add support in Helm chart to declaratively create logstream and set retention.

To allow that setup we need to ensure log stream retention can be set before log stream has events (i.e. initialized)

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

It is common for users to create stream and set the retention
(and be done with initial config) before sending logs to the
log stream.

Accordingly we're going to add support in Helm chart to
declaratively create logstream and set retention.

To allow that setup we need to ensure log stream retention
can be set before log stream has events (i.e. initialized)
@nitisht
Copy link
Member Author

nitisht commented May 7, 2023

Required for #397

@nitisht nitisht merged commit d1e4394 into parseablehq:main May 7, 2023
@nitisht nitisht deleted the retention-init branch May 7, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant